84677 - Do default priority for patterns right

Status: VERIFIED FIXED

(Core :: XSLT, defect, P5)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We do quite alot of extra work in ::getDefaultPriority since we match the node 
against the pattern. Also some of the priorities are wrong. I'll attach a 
temporary patch but we need to get bug 75102 in before I can make a real patch

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: temp patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: attempt one

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

here goes...
Much of this patch is comment fixes wrt removal of patterns. The code changes 
should be pretty straight forward.
I've left the |XXX::getDefaultPriority(...)| lines unchanged on purpose even 
though most of them is more then 80 columns wide, the resaon is that i'm gonna 
remove the |Node* context| argument soon since it's not used which will make 
the lines short enough (in that patch i'm gonna move down the {s aswell).

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

it would really be nice if we could get this on the branch as we currently 
don't support even support priorities (see fix of ProcessorState::findTemplate)

Comment 5

[Axel Hecht]

Attribute- and ElementExpr: newlines in early returns
FilterExpr: assertion, Filter is not allowed in Patterns.
            if( -> if (

r=axel if you done that.

Axel

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: fixed Pikes comments

Comment 7

[Mike Shaver (:shaver emeritus)]

sr=shaver

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in

Comment 9

[Axel Hecht]

bitching buttons, verfication spam