846786 - java.lang.NullPointerException: at org.mozilla.gecko.gfx.GfxInfoThread.hasData(GfxInfoThread.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Scoobidiver (away)]

It has been hit by four users in 22.0a1/20130103, including bp-540e2414-5b13-429e-9812-6ea3a2130301. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b0e08db3bc2a&tochange=993d7aff3109
It's likely a regression from bug 844275.

java.lang.NullPointerException
	at org.mozilla.gecko.gfx.GfxInfoThread.hasData(GfxInfoThread.java:38)
	at org.mozilla.gecko.gfx.GLController$1.run(GLController.java:129)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4507)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:978)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:745)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.gfx.GfxInfoThread.hasData%28GfxInfoThread.java%29

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Yeah, my mistake. I didn't realize there things other than compositor creation that can call GfxInfo::EnsureInitializedFromGfxInfoData, so it is possible for GfxInfoThread.sInstance to be null when GLController.mCompositorCreated is false. Should be an easy fix.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

I'm still building this but I'm pretty confident in it. Note that another option is to make GfxInfoThread.getData() not null out sInstance, but then we'll leak the GfxInfoThread instance unnecessarily, so I prefer this approach.

Comment 3

[Scoobidiver (away)]

It's #5 top crasher over the last week.

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 720042 [details] [diff] [review]
Patch

Review of attachment 720042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok, but at this point I think you're a much better judge of this than I am...

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69043531c962

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/69043531c962

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 720042 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 844275
User impact if declined: needs to land as a follow-up to bug 844275
Testing completed (on m-c, etc.): on m-c, aurora try build at https://tbpl.mozilla.org/?tree=Try&rev=26b79db37644
Risk to taking this patch (and alternatives if risky): low risk, fennec only
String or UUID changes made by this patch: none

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 720042 [details] [diff] [review]
Patch

bug 844275 is recently approved on aurora.Need to approve this to avoid introducing the top-crasher in Fx21

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5aa5a4e399e1