846818 - Show developers their error for in-app payments

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Kumar McMillan [:kumar]]

When a developer makes a mistake that triggers an unexpected exception, we mostly do not show it on the screen because this would be confusing to the user who is making the purchase.

Let's return the error message in the paymentFailed(errorMsg) callback.
https://wiki.mozilla.org/WebAPI/WebPaymentProvider#Completion

Developers will get this in their app where they can log it or retrieve it from a console.

The error can be bubbled up here https://github.com/mozilla/webpay/blob/0db82714bde136a5b8c2c4968296eae78afe079d/webpay/base/utils.py#L35

Note: we currently do show errors on screen if the request was a simulation. This new feature is to bubble up *all* errors, such as form validation errors, through the paymentFailed() callback.

Comment 1

[Kumar McMillan [:kumar]]

I think bug 887471 might make this moot

Comment 2

[Kumar McMillan [:kumar]]

Nevermind about comment #1, this bug is about passing the error code to paymentFailed()

Comment 3

[Kumar McMillan [:kumar]]

r? https://github.com/mozilla/webpay/pull/293 (also needs a one line fireplace patch)

Comment 4

[Kumar McMillan [:kumar]]

webpay: https://github.com/mozilla/webpay/commit/8b2e19963bff7bbe54d0f6e9a43348d60d7d11b5
fireplace: https://github.com/mozilla/fireplace/commit/8005229e66612f785ac3deb960f596d63bd67e08

Comment 5

[Iulian Timis]

Please add STR here or mark it with [qa-] if no QA is needed.