Closed
Bug 846818
Opened 12 years ago
Closed 11 years ago
Show developers their error for in-app payments
Categories
(Marketplace Graveyard :: Payments/Refunds, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-09-24
People
(Reporter: kumar, Assigned: kumar)
References
Details
(Whiteboard: p=2 [qa-])
When a developer makes a mistake that triggers an unexpected exception, we mostly do not show it on the screen because this would be confusing to the user who is making the purchase.
Let's return the error message in the paymentFailed(errorMsg) callback.
https://wiki.mozilla.org/WebAPI/WebPaymentProvider#Completion
Developers will get this in their app where they can log it or retrieve it from a console.
The error can be bubbled up here https://github.com/mozilla/webpay/blob/0db82714bde136a5b8c2c4968296eae78afe079d/webpay/base/utils.py#L35
Note: we currently do show errors on screen if the request was a simulation. This new feature is to bubble up *all* errors, such as form validation errors, through the paymentFailed() callback.
Assignee | ||
Updated•12 years ago
|
Blocks: marketplace-payments
Priority: -- → P3
Updated•12 years ago
|
Whiteboard: p=2
Updated•11 years ago
|
Version: 1.2 → 1.3
Assignee | ||
Comment 1•11 years ago
|
||
I think bug 887471 might make this moot
Updated•11 years ago
|
Assignee: nobody → kumar.mcmillan
Assignee | ||
Comment 2•11 years ago
|
||
Nevermind about comment #1, this bug is about passing the error code to paymentFailed()
Assignee | ||
Comment 3•11 years ago
|
||
r? https://github.com/mozilla/webpay/pull/293 (also needs a one line fireplace patch)
Target Milestone: --- → 2013-09-24
Assignee | ||
Comment 4•11 years ago
|
||
webpay: https://github.com/mozilla/webpay/commit/8b2e19963bff7bbe54d0f6e9a43348d60d7d11b5
fireplace: https://github.com/mozilla/fireplace/commit/8005229e66612f785ac3deb960f596d63bd67e08
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Please add STR here or mark it with [qa-] if no QA is needed.
Flags: needinfo?(kumar.mcmillan)
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(kumar.mcmillan)
Whiteboard: p=2 → p=2 [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•