846856 - TEST-UNEXPECTED-FAIL | tests/test-window-utils-private-browsing.testSettingActiveWindowIgnoresPrivateWindow | Correct active window [1]

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20206264&tree=Jetpack&full=1

Comment 1

[Ed Morley [:emorley]]

(Keyword needed for this to appear in TBPL bug suggestions)

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/835

Pointer to Github pull-request

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 721295 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/835

Looks good.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/98a049090bc8391747a402e412b72ab346fdce37
Bug 846856: TEST-UNEXPECTED-FAIL | tests/test-window-utils-private-browsing.testSettingActiveWindowIgnoresPrivateWindow | Correct active window [1]

It looks like getMostRecentBrowserWindow() doesn't return the window focused when the "focus" event occurs, but instead sometime afterward..

https://github.com/mozilla/addon-sdk/commit/d92a2da7e742bd76fd50a416b5d0c60dc9e7f39c
Merge pull request #835 from erikvold/846856

Fix Bug 846856 - TEST-UNEXPECTED-FAIL | tests/test-window-utils-private-browsing.testSettingActiveWindowIgnoresPrivateWindow | Correct active window [1] r=@ochameau