need to support swapping doc shells when only one is in a popup

RESOLVED FIXED in mozilla22

Status

()

Core
Layout: View Rendering
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
mozilla22
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 720077 [details] [diff] [review]
patch

In nsSubDocumentFrame::BeginSwapDocShells we assert that we are not doing this. But sadly this is a common thing to do with the addon sdk for example: opening a panel and swapping a document into the panel.
Attachment #720077 - Flags: review?(matt.woodrow)
While you're here:
s/the current frame and all descendant frames/aFrame and its descendants/

Would it be possible to write a testcase?

The existing nsGkAtoms::listControlFrame check ... shouldn't it also check that
the frame IsInDropDownMode() ?  (maybe it doesn't matter in practice though)
(Assignee)

Comment 2

5 years ago
(In reply to Mats Palmgren [:mats] from comment #1)
> The existing nsGkAtoms::listControlFrame check ... shouldn't it also check
> that
> the frame IsInDropDownMode() ?  (maybe it doesn't matter in practice though)

Good call. I fixed one case of that in bug 843979 already. I'll add a separate patch to fix that.
(Assignee)

Comment 3

5 years ago
Created attachment 720174 [details] [diff] [review]
make sure list control frames are actually popups
Attachment #720174 - Flags: review?(matspal)

Updated

5 years ago
Attachment #720174 - Flags: review?(matspal) → review+
Attachment #720077 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/0e774158e873
https://hg.mozilla.org/mozilla-central/rev/a3d0d869bd50
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.