Argument definitions should use .define(), not str() in ClassConstructor::define

RESOLVED FIXED in mozilla22

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla22
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 839088 changed Argument to require the use of .declare() and .define() instead of str(), but didn't change all of the places that should use .define().  I came across this with my example JS implementation, where constructor arguments ended up coming out like |<Codegen.Argument instance at 0x1007477a0>|.
(Assignee)

Comment 1

5 years ago
Created attachment 720186 [details] [diff] [review]
fix ClassConstructor::define

It looks like this is only a problem in one place.  I audited the code using the scientific approach of looking for places that used "args" and places that did "str(a", and didn't find anything else.
(Assignee)

Updated

5 years ago
Summary: Argument definitions should use .define(), not str() → Argument definitions should use .define(), not str() in ClassConstructor::define
(Assignee)

Updated

5 years ago
Attachment #720186 - Flags: review?(bzbarsky)
Comment on attachment 720186 [details] [diff] [review]
fix ClassConstructor::define

Oops.  r=me
Attachment #720186 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/1d0f2cba284a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.