846973 - BaselineCompiler: Change all uses of lookupProperty to be effectless

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

We use JSObject::lookupProperty in many places in the BaselineIC, without first checking obj->hasIdempotentProtoChain().

These should all use a helper method that does the following:
  if hasIdempotentProtoChain() is true, uses lookupProperty.
  otherwise, uses nativeLookup

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Patch

Comment 2

[Jan de Mooij [:jandem]]

Hm, why is this a problem for us and not a problem with JM / Ion ICs?

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 720227 [details] [diff] [review]
Patch

Review of attachment 720227 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineIC.cpp
@@ +2381,5 @@
> +    if (obj->hasIdempotentProtoChain()) {
> +        if (!JSObject::lookupProperty(cx, obj, name, holder, shape))
> +            return false;
> +    } else {
> +        shape.set(obj->nativeLookup(cx, NameToId(name)));

I think you can just remove the "else", or if we have to keep it change it to "else if (!obj->isNative())"

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #3)
> change it to "else if (!obj->isNative())"

Er, no "!", of course.

Comment 5

[Kannan Vijayan [:djvj]]

https://hg.mozilla.org/projects/ionmonkey/rev/0a4d014de179

Watching before closing.