Closed
Bug 847007
Opened 13 years ago
Closed 13 years ago
Fix some content includes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(2 files, 2 obsolete files)
|
9.66 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
|
39.63 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #720246 -
Flags: review?(Ms2ger)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #720253 -
Flags: review?(Ms2ger)
|
||
Comment 2•13 years ago
|
||
You're conflicting with bug 833009 already :/
|
|
Assignee | |
Comment 3•13 years ago
|
||
That bug is marked fixed. What is the conflict?
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 720246 [details] [diff] [review]
Part 1: nsIDocument
I promise speedy reviews if you get these updated :)
Attachment #720246 -
Flags: review?(Ms2ger)
|
|
||
Updated•13 years ago
|
Attachment #720253 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #720246 -
Attachment is obsolete: true
Attachment #727850 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #720253 -
Attachment is obsolete: true
Attachment #727851 -
Flags: review?(Ms2ger)
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 727850 [details] [diff] [review]
Part 1: nsIDocument
Review of attachment 727850 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
::: content/events/src/nsEventStateManager.h
@@ -21,5 @@
> #include "nsCycleCollectionParticipant.h"
> #include "nsIMarkupDocumentViewer.h"
> #include "nsIScrollableFrame.h"
> #include "nsFocusManager.h"
> -#include "nsIDocument.h"
Someone wanted to be really sure, it seems.
Attachment #727850 -
Flags: review?(Ms2ger) → review+
|
|
||
Updated•13 years ago
|
Attachment #727851 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
||
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/55ddaf3f474f
https://hg.mozilla.org/mozilla-central/rev/c1e0d7e7b164
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•