847028 - Warning for disabled plugin should mention name of inactive plug-in the user has to enable

Status: RESOLVED DUPLICATE of bug 1101153

(Core Graveyard :: Plug-ins, enhancement, P5)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Nightly 20130301, Windows XP SP3 32 bit

If a plug-in needed by the page has been disabled, a message is shown: "This plugin is disabled. Manage plugins...". E.g. go to http://www.kesel.de/flashex.htm#Produktlogos with plugins disabled.

Expected result:
Warning tells user which plugin to enable.

Comment 1

[Georg Fritzsche [:gfritzsche]]

The "PluginDisabled" handler:
http://hg.mozilla.org/mozilla-central/annotate/0a91da5f5eab/browser/base/content/browser-plugins.js#l213
http://hg.mozilla.org/mozilla-central/diff/6c3b228838e5/toolkit/locales/en-US/chrome/mozapps/plugins/plugins.dtd

... should just do message formatting to insert the plugin name like the handler for "ClickToPlay":
http://hg.mozilla.org/mozilla-central/annotate/0a91da5f5eab/browser/base/content/browser-plugins.js#l213
http://hg.mozilla.org/mozilla-central/annotate/0a91da5f5eab

Comment 2

[Benjamin Smedberg]

cers is working on this UI as part of removing PFS, I believe. For missing/disabled plugins, I believe our current plan is not to show any in-page UI at all, but to to include the plugin in the location bar doorhanger.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Let's recheck if this still applies after that UI overhaul then.