847074 - Runescape WebGL bestiary explicitly requires Chrome

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: English US, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

http://services.runescape.com/m=itemdb_rs/bestiary/

Says:

"Can only be viewed with a browser that fully supports HTML5 and WebGL"

Has this source code that explicitly requires Chrome >= 21:

var correctBrowserInstalled = /chrome/.test(navigator.userAgent.toLowerCase()) && (parseInt(navigator.appVersion.match(/Chrome\/(\d+)\./)[1], 10) > 21),
screenWidth = screen.width;
if (correctBrowserInstalled === true) {
    $("html").addClass("bestiarytech");
    if (screenWidth < 800) {
        $("html").addClass("smallScreen");
    }
}
else {

    document.title = "RuneScape Bestiary - Please install Chrome to view this Feature";
}

Comment 1

[JK]

This is what you get if you spoof the userAgent and appVersion of Chrome:

"It looks like your browser doesn't fully support HTML5

If you are using Google Chrome, please make sure you are running the latest version, otherwise, please download Chrome directly from Google and try again."

Comment 2

[JK]

(In reply to Chris Endicott from Bug 504553 - WebSocket in Workers comment #33)
> I've been on the CC list for this issue for a while - if there's anything we
> (Jagex) can do, please do get in touch with me directly. Of course as soon
> as a patch hits release builds, we'll remove the Chrome only guard on the
> Bestiary and let our player base know.
> 
> We have internal release targets for the full RuneScape game on this
> platform in the next couple of months and of course we'd love for it to run
> on FireFox at launch.
> 
> Many thanks.

If you got rid of the user agent sniff (which is considered a deprecated way of programming that should almost never be used), the application should start working immediately on the Nightly branch when the fix lands.

It's important that it works on the Nightly branch immediately when it lands so that the community can test it for bugs (without having to override the user agent).

Comment 3

[Chris Endicott]

Next time we update the Bestiary, we'll remove the user agent check and just fail over to the missing feature page we have behind it. This is similar behavior to that which users will get when accessing the closed beta of the game client from next week.

Comment 4

[Chris Endicott]

And the check is gone.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

I just re-tested in Firefox Nightly 23.0a1 (2013-04-08), and get:

> It looks like your browser doesn't fully support HTML5

> If you are using Google Chrome, please make sure you are running the latest version, otherwise, please download Chrome directly from Google and try again.

Comment 6

[Chris Endicott]

That's correct.

It's running a battery of tests on the browser and if any of them fail it will go to that screen (or a specific WebGL one in the case of a WebGL failure). In FireFox's case it's failing the web sockets on web workers test (discussed in bug https://bugzilla.mozilla.org/show_bug.cgi?id=504553).

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

OK, the present bug is fixed then. Thanks.

I also would appreciate if you could make the error message a little bit more precise than "It looks like your browser doesn't fully support HTML5" then.