Closed Bug 847116 Opened 11 years ago Closed 11 years ago

Convert SVGFEBlendElement to WebIDL

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(1 file)

      No description provided.
Blocks: 832155
Attached patch PatchSplinter Review
This patch is giant because it copies nsSVGFilters.cpp.  They should get smaller as filter elements move out of this file.
Attachment #720477 - Flags: review?(Ms2ger)
Comment on attachment 720477 [details] [diff] [review]
Patch

Review of attachment 720477 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/nsSVGFilters.cpp
@@ +22,5 @@
> +  {&nsGkAtoms::normal, SVG_FEBLEND_MODE_NORMAL},
> +  {&nsGkAtoms::multiply, SVG_FEBLEND_MODE_MULTIPLY},
> +  {&nsGkAtoms::screen, SVG_FEBLEND_MODE_SCREEN},
> +  {&nsGkAtoms::darken, SVG_FEBLEND_MODE_DARKEN},
> +  {&nsGkAtoms::lighten, SVG_FEBLEND_MODE_LIGHTEN},

Nit: {}s on their own line for the SVGFEBlendElement constructor.

@@ +50,5 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFEBlendElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFEBlendElement, nsIDOMNode, nsIDOMElement,
> +                           nsIDOMSVGElement)
> +NS_INTERFACE_MAP_END_INHERITING(SVGFEBlendElementBase)

NS_IMPL_ISUPPORTS_INHERITED3(SVGFEBlendElement, SVGFEBlendElementBase,
                             nsIDOMNode, nsIDOMElement, nsIDOMSVGElement)

::: dom/webidl/SVGFilterPrimitiveStandardAttributes.webidl
@@ +9,5 @@
> + * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
> + * liability, trademark and document use rules apply.
> + */
> +
> +interface SVGAnimatedString;

Hmm, this isn't on WebIDL yet? Someone should fix that ;)
Attachment #720477 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/35f383c97e07
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: