Closed Bug 847139 Opened 7 years ago Closed 7 years ago

Crash with caretPositionFromPoint, svg.text.css-frames.enabled

Categories

(Core :: SVG, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jruderman, Assigned: longsonr)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, crash, testcase)

Crash Data

Attachments

(3 files)

Attached image testcase
With:
  user_pref("svg.text.css-frames.enabled", true);

ASSERTION: null nsSVGPathGeometry frame: 'mMarkedFrame', file layout/svg/nsSVGMarkerFrame.cpp

Crash [@ nsSVGMarkerFrame::GetCanvasTM]
On Windows: bp-64bdcd64-c13b-4f64-9eb8-62bae2130303.
Crash Signature: [@ nsSVGMarkerFrame::GetCanvasTM(unsigned int) ]
OS: Mac OS X → All
Hardware: x86_64 → All
Attached patch patchSplinter Review
We only set up the canvasTM for markers and other referenced objects when painting (as the marker may be referenced by many different frames) or in getFrameForPoint. If a method is callable outside of those circumstances we need to pass false rather than true to UpdateGlyphPositioning
Assignee: nobody → longsonr
Attachment #720772 - Flags: review?(dholbert)
Comment on attachment 720772 [details] [diff] [review]
patch

Seems reasonable.
Attachment #720772 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/4cd1797dd7e0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Still repros for me.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Crashes at a different place now and I'm not sure how to correct that without input from heycam
Assignee: longsonr → nobody
Comment on attachment 728708 [details] [diff] [review]
perhaps we should just ignore text in <defs>

That's reasonable.
Attachment #728708 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/cd8c7fc2b29d
Assignee: nobody → longsonr
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.