847205 - BaselineCompiler: Add optimized (Double BITOP Int32) stubs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

Mandreel hits this a lot.  For now handling BITAND and BITOR is sufficient.

Comment 1

[Brian Hackett [Laid off!]]

Are you testing with off thread compilation on Mandreel?  Because of the different compilation thresholds, we should be Ion compiling everything that is hot on Mandreel when compiling off thread, but not in other builds.

Comment 2

[Kannan Vijayan [:djvj]]

You're right, with off thread compilation on Mandreel these don't show up.

However, box2d and navier stokes do hit them pretty heavily in that case.

Comment 3

[Kannan Vijayan [:djvj]]

Attachment: Patch.

Just adds handling for bitxor, bitand, and bitor ops for (Double, Int32) or (Int32, Double).

Cuts out another 150k or so fallback hits between box2d and navier stokes.

Comment 4

[Brian Hackett [Laid off!]]

Comment on attachment 720540 [details] [diff] [review]
Patch.

Review of attachment 720540 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineIC.cpp
@@ +2293,5 @@
>                  return false;
>              stub->addNewStub(doubleStub);
>              return true;
>            }
> +          default: // Fall-through

rm comment

Comment 5

[Kannan Vijayan [:djvj]]

Fixed and pushed: https://hg.mozilla.org/projects/ionmonkey/rev/a1af5476f427
Waiting for tbpl to close.