847244 - New click-to-play state should influence how plugins are sorted in the Add-ons Manager UI

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Not 100% sure we want this, but... 

When add-ons are shown in a list, we sort the enabled ones first and the disabled ones last. With bug 549697, we have a new intermediate state of "ask me". It may make sense to take that into account when sorting plugins - and sort the "ask me" state in between the equivalents of enabled and disabled. With the current patch in bug 549697, they're sorted the same as enabled plugins.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Boriss: Thoughts?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Vaguely remember some agreement over this.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Will need to update sortElements() in toolkit/mozapps/extensions/content/extensions.js

Add-ons are of a type, as determined by their 'type' property. Add-on types also have a set of properties, that define how that specific type should behave - you can look this up via AddonManager.addonTypes - which is a hash mapping the type ID (a string) to a AddonType object. An AddonType object has a 'flags' property, which is a bitfield. If it includes TYPE_SUPPORTS_ASK_TO_ACTIVATE, then such an add-on's 'userDisabled' property can have the value STATE_ASK_TO_ACTIVATE.

We want add-ons in the ask-to-activate state to be sorted so they come directly after enabled add-ons.

Comment 4

[Alex Bardas :alexbardas]

Attachment: Take into account askToActivate state for plugin Addon objects and add new browser tests

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8464346 [details] [diff] [review]
Take into account askToActivate state for plugin Addon objects and add new browser tests

Review of attachment 8464346 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks :)

::: toolkit/mozapps/extensions/test/browser/browser_sorting_plugins.js
@@ +72,5 @@
> +  var node = list.firstChild;
> +  var baseId = "@tests.mozilla.org";
> +  while (node) {
> +    var id = node.getAttribute("value");
> +    if (id && id.substring(id.length - baseId.length) == baseId)

Nit: Now days we can use .endsWith(), which makes this a lot cleaner - see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith

Comment 6

[Alex Bardas :alexbardas]

Attachment: Take into account askToActivate state for plugin Addon objects and add new browser tests

Use .endsWith instead of .substring in test files, based on :Unfocused suggestion.

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8465615 [details] [diff] [review]
Take into account askToActivate state for plugin Addon objects and add new browser tests

I pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=3063670d0ae7

Comment 8

[Drew Willcoxon :adw]

Try looks OK so far.

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/b5f3d8eaa757

Congrats!

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b5f3d8eaa757