Last Comment Bug 847259 - (Linux) drag and drop rss feed link from browser to folderpane does nothing
: (Linux) drag and drop rss feed link from browser to folderpane does nothing
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: 17 Branch
: x86 Linux
: -- normal (vote)
: Thunderbird 23.0
Assigned To: alta88
:
:
Mentors:
Depends on:
Blocks: 795002
  Show dependency treegraph
 
Reported: 2013-03-03 19:15 PST by fengyuan
Modified: 2013-05-11 07:07 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.16 KB, patch)
2013-04-25 07:36 PDT, alta88
mkmelin+mozilla: review+
Details | Diff | Splinter Review

Description fengyuan 2013-03-03 19:15:51 PST
Solaris 12, Thunderbird 17.

Drag and drop rss link from FF to folderpane simply never works

Step:
-have TB with a blog and feeds account
-have a page with rss link, like www.nytimes.com/services/xml/rss/index.html
-drag from browser to account or folder under Blogs

Expected: 
new feed added and refreshed.

Actual: 
Nothing happened. Error message found in Error console:
    TypeError: dt.mozGetDataAt(...) is null
    chrome://messenger/content/folderPane.js
Comment 1 fengyuan 2013-03-04 00:43:50 PST
Also happens in Thunderbird 17.3 / Linux
Comment 2 alta88 2013-03-05 07:56:51 PST
this works in winxp/win7, but on linux the data xfer filetype for a url is "application/x-moz-file", which then fails, and the feed subscribe part is not invoked.

this is likely a core dnd issue.
Comment 3 alta88 2013-04-25 07:36:54 PDT
Created attachment 741857 [details] [diff] [review]
patch


but regardless of the filetype, it's simple to change the dnd processing order and try if the folder is rss.
Comment 4 Magnus Melin 2013-04-25 12:14:41 PDT
Comment on attachment 741857 [details] [diff] [review]
patch

Review of attachment 741857 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! r=mkmelin
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-04-27 18:49:40 PDT
https://hg.mozilla.org/comm-central/rev/f83862bd189f

Note You need to log in before you can comment on or make changes to this bug.