All users were logged out of Bugzilla on October 13th, 2018

Need to add customizing power off animation.

VERIFIED FIXED

Status

VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: rexboy, Assigned: rexboy)

Tracking

unspecified
x86_64
Linux
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 verified, b2g18-v1.0.1 verified)

Details

Attachments

(1 attachment)

We need to implement customizing poweroff animation.

Customizing power on animation has been implemented in bug 838104.  For poweroff, same format (png and mp4) would be allowed as far.

Peter, may you suggest that if we want to allow partners to customize poweroff animation, shall it just replace the original one (the three rings) or let these two animations appear in sequence?
Thanks for the help!
Flags: needinfo?(pla)
Created attachment 721125 [details]
Patch

Partners should put their customized poweroff logo at
<CUSTOMIZE DIR>/power/carrier_power_off.png or
<CUSTOMIZE DIR>/power/carrier_power_off.mp4

I found that mozPower can't be replaced with mock, so the unit test is now just for the logo loader.

Tim, may you review this patch?  Thanks for the help!
Attachment #721125 - Flags: review?(timdream)
Comment on attachment 721125 [details]
Patch

please fix some nits before merge!
Attachment #721125 - Flags: review?(timdream) → review+
Thanks for reviewing Tim!  Mistakes are fixed.

merged here:
https://github.com/mozilla-b2g/gaia/commit/d126a77d90c98a25c48ba34d43e59cbf97c565e2

It's still tef?.  If it's marked tef+ later, I will uplift it to v1-train and 1.0.1 branch.
blocking-b2g: tef? → tef+
status-b2g18: --- → fixed
status-b2g18-v1.0.1: --- → fixed

Comment 5

6 years ago
(In reply to KM Lee [:rexboy] from comment #0)
> We need to implement customizing poweroff animation.
> 
> Customizing power on animation has been implemented in bug 838104.  For
> poweroff, same format (png and mp4) would be allowed as far.
> 
> Peter, may you suggest that if we want to allow partners to customize
> poweroff animation, shall it just replace the original one (the three rings)
> or let these two animations appear in sequence?
> Thanks for the help!

Hi rexboy, sorry for the late response.  My recommendation is that if you allow customization, it should replace the existing one.  Appending it to the existing 3 rings would make the customization almost pointless.
Flags: needinfo?(pla)
(In reply to Peter La from comment #5)
> (In reply to KM Lee [:rexboy] from comment #0)
> Hi rexboy, sorry for the late response.  My recommendation is that if you
> allow customization, it should replace the existing one.  Appending it to
> the existing 3 rings would make the customization almost pointless.
OK, that's certainly what we do in this patch.
Thanks for reply!
Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 8

6 years ago
Edited an already existing but to make sure people look for the animation when powering off.
https://moztrap.mozilla.org/manage/cases/?filter-id=1330
Flags: in-moztrap-

Updated

6 years ago
Flags: needinfo?

Updated

6 years ago
Flags: needinfo?(rexboy)
Keywords: verifyme

Comment 9

6 years ago
This issue appears to be fixed on Unagi device
Build ID: 20130402070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ccec751a468e
Gaia: ee0bef61c0a25c806dd1eec5a4e047bc418a5f73

also, issue appears fixed on build 20130402070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68c8a883cfc0
Gaia: 1c38c91bb16f2bf0d5066c4787d2249463f61bb3

Animation works properly.
Status: RESOLVED → VERIFIED
Flags: needinfo?
Flags: needinfo?(rexboy)
According to comment9,delete keywords verifyme.
Keywords: verifyme
status-b2g18: fixed → verified
status-b2g18-v1.0.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.