IonMonkey: FastInvokeGuard should only construct an IonContext if it needs one

RESOLVED FIXED in mozilla22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

unspecified
mozilla22
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 720745 [details] [diff] [review]
Patch

In threadsafe builds, constructing an IonContext is relatively expensive since it involves accessing TLS.

The attached patch changes FastInvokeGuard to only construct an IonContext if it needs one. This wins a few hundred points on v8-regexp.
Attachment #720745 - Flags: review?(hv1989)
Comment on attachment 720745 [details] [diff] [review]
Patch

Review of attachment 720745 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I understand this code, this looks correct.
Attachment #720745 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/1183cd0b083a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.