Closed
Bug 847450
Opened 11 years ago
Closed 11 years ago
IonMonkey: FastInvokeGuard should only construct an IonContext if it needs one
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.69 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
In threadsafe builds, constructing an IonContext is relatively expensive since it involves accessing TLS. The attached patch changes FastInvokeGuard to only construct an IonContext if it needs one. This wins a few hundred points on v8-regexp.
Attachment #720745 -
Flags: review?(hv1989)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 720745 [details] [diff] [review] Patch Review of attachment 720745 [details] [diff] [review]: ----------------------------------------------------------------- As far as I understand this code, this looks correct.
Attachment #720745 -
Flags: review?(hv1989) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1183cd0b083a
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1183cd0b083a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•