Closed Bug 847450 Opened 9 years ago Closed 9 years ago

IonMonkey: FastInvokeGuard should only construct an IonContext if it needs one

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
In threadsafe builds, constructing an IonContext is relatively expensive since it involves accessing TLS.

The attached patch changes FastInvokeGuard to only construct an IonContext if it needs one. This wins a few hundred points on v8-regexp.
Attachment #720745 - Flags: review?(hv1989)
Comment on attachment 720745 [details] [diff] [review]
Patch

Review of attachment 720745 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I understand this code, this looks correct.
Attachment #720745 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/1183cd0b083a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.