847473 - [Calendar][Perf] Delay additional CSS resources

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Kevin Grandon :kgrandon]

It appears there are a bunch of CSS resources in index.html that we can delay. We should be able to delay things like forms, buttons, and overlays.

Comment 1

[James Lal [:lightsofapollo]]

@kgrandon

We can do this with the new load_config.js and a new handler like sharedCss/sharedStyle.

Unrelated we need to kill the web_asset.js junk and use real building blocks which will help us lazy load more (but may actually slow things down... I don't know the perf impact of more css files).

Comment 3

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8525

Pointer to Github pull-request

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 722481 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8525

kgrandon's work + my reluctance to completely kill mozAlarms shim.

Comment 5

[James Lal [:lightsofapollo]]

Comment on attachment 722481 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8525

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Slower initial load...
This is a great quick win with minimal changes... Perf tests indicated a 80-100ms reduction in initial display time.
Testing completed: 
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:

Comment 6

[Kevin Grandon :kgrandon]

This has landed in master: https://github.com/mozilla-b2g/gaia/commit/df175e5f288debe3bde56b20e59292a634ff3843

Comment 7

[Alex Keybl [:akeybl]]

Given this is low risk, tracking so that this is automatically uplifted after a couple of days of bake time on master.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit df175e5f288debe3bde56b20e59292a634ff3843 as:
v1-train: 4ab41bedc19c3ca097f3eb999f2c6cb238b359bf