847478 - [BB][input_areas] - Input text should be aligned with header

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Input Area text should be left aligned with header

Text in input fields should be aligned with the header (30px left margin)

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Before-After

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 3

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 722950 [details]
> Before-After

Text alignment looks good now.  But why did 'account type' change?  It should go back to being a subheading as it was in your first patch. Thanks!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Oh ... my mistake ... I just put the screenshot image on wrong place(in the middle) I will update the image later.

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Actualy the image is correct ... The "Account type" is fixed in Bug 844978

Comment 6

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #5)
> Actualy the image is correct ... The "Account type" is fixed in Bug 844978

ok, thanks for letting me know.  This is good then :).

Comment 7

[Eric Pang [:epang] UX]

Part of LG's request for font updates.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 9

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/cd9e439a33caba739cf4789ed64728ed067d2017

Comment 10

[Julien Wajsberg [:julienw]]

Should this get uplifted to v1.1 or is too risky ?

Comment 11

[Cody Roesch [:croesch]]

I noticed that email and several other apps are still not fixed even though you fixed the building block, should I file individual bugs for individual apps?  or should I file one bug in regards the other apps?

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We should open separate bugs for each app because the implementation of the [BB] is different ... and it's related to the layout of each app (e.g the left margins/paddings of the inputs are different for each app)

Comment 13

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #12)
> We should open separate bugs for each app because the implementation of the
> [BB] is different ... and it's related to the layout of each app (e.g the
> left margins/paddings of the inputs are different for each app)

Hi Pavel, are the headers (text) not positioned 30px on each app?

Comment 14

[Julien Wajsberg [:julienw]]

And my comment 10 was not answered...

Comment 15

[Eric Pang [:epang] UX]

(In reply to Julien Wajsberg [:julienw] from comment #14)
> And my comment 10 was not answered...

Pavel, based on Julien's comment, if it's always 30px left padding for text in input fields would this be risky to uplift to v1.1?

Comment 16

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Julien Wajsberg [:julienw] from comment #10)
> Should this get uplifted to v1.1 or is too risky ?

Sorry for the delay Julien .. I think the risk is very low ... I made only few css adjustments

Comment 17

[Eric Pang [:epang] UX]

Hi Sergiy,

Wanted to loop you into this bug as well.  We've proposed having all input text left align with the header (at 30px). With the text all aligned we find everything looks more oragnized and clean.

Wanted to make sure you agree before this bug moves forward. Let us know your thoughts on this.  Thanks!

Comment 18

[Sergi]

Yes, that's correct. We should use a left padding of 30px for the input text, while the input field should have a 15px padding. 

Looks perfect to me.

Thanks!

Comment 19

[Julien Wajsberg [:julienw]]

Comment on attachment 722952 [details]
patch for Gaia repo

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: unpleasant layout
Testing completed: yes, this is in master for 1,50 months.
Risk to taking this patch (and alternatives if risky): very low, only small css changes. The worst impact is that some text could be moved by a few pixels.
String or UUID changes made by this patch: none

Comment 20

[Eric Pang [:epang] UX]

(In reply to Sergi from comment #18)
> Yes, that's correct. We should use a left padding of 30px for the input
> text, while the input field should have a 15px padding. 
> 
> Looks perfect to me.
> 
> Thanks!

great thanks Sergi!

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted cd9e439a33caba739cf4789ed64728ed067d2017 to:
v1-train: 06153e130a98ac0179df460c5d741e152fc5d4b5