847536 - migrate GENERATED_DIRS* assignments to moz.build files

Status: NEW

(Firefox Build System :: General, enhancement)

Comment 1

[Joey Armstrong [:joey]]

Attachment: move GENERATED_DIRS to moz.build (logic).

Comment 2

[Joey Armstrong [:joey]]

Comment on attachment 753603 [details] [diff] [review]
move GENERATED_DIRS to moz.build (logic).

Added a passthrough variable conversion for GENERATED_DIRS.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 753603 [details] [diff] [review]
move GENERATED_DIRS to moz.build (logic).

Review of attachment 753603 [details] [diff] [review]:
-----------------------------------------------------------------

Philosophically, I don't think GENERATED_DIRS should need to exist in user-facing files. The build backend should magically handle everything. But, until we get to that ideal end state, I reckon this might be a necessary evil. That being said, I *think* that every GENERATED_DIRS inside a Makefile.in is likely tied to a one-off rule in said Makefile.in. Therefore, we should ignore GENERATED_DIRS and deal with them as part of adding moz.build support for the underlying functionality that requires them.