JPEG decoder needs to handle extraneous size writes

RESOLVED INVALID

Status

()

Core
ImageLib
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

Trunk
mozilla22
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 720845 [details] [diff] [review]
handle writes to JPEG decoder after finding the size

The way we write data to the JPEG decoder in the case of a size decode, we currently get lucky and never need to handle subsequent writes - or, at least, when it comes up it doesn't cause any issues. However, we should transparently handle this since it's allowed per the decoder API.
Attachment #720845 - Flags: review?(seth)
Comment on attachment 720845 [details] [diff] [review]
handle writes to JPEG decoder after finding the size

Review of attachment 720845 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #720845 - Flags: review?(seth) → review+
(Assignee)

Comment 2

5 years ago
 https://hg.mozilla.org/integration/mozilla-inbound/rev/45d4f7b16c2f
Assignee: nobody → joe
Target Milestone: --- → mozilla22
Backed out for build bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d81fc67e6ed
(Assignee)

Comment 4

5 years ago
I am terrible at programming. This depends on hanges in bug 716140, so I'm making this patch part <mumble> of that bug.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
Bummer. Bug 716140 has a lot of patches as it is!
You need to log in before you can comment on or make changes to this bug.