Closed
Bug 847559
Opened 11 years ago
Closed 11 years ago
JPEG decoder needs to handle extraneous size writes
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
INVALID
mozilla22
People
(Reporter: joe, Assigned: joe)
References
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
The way we write data to the JPEG decoder in the case of a size decode, we currently get lucky and never need to handle subsequent writes - or, at least, when it comes up it doesn't cause any issues. However, we should transparently handle this since it's allowed per the decoder API.
Attachment #720845 -
Flags: review?(seth)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 720845 [details] [diff] [review] handle writes to JPEG decoder after finding the size Review of attachment 720845 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #720845 -
Flags: review?(seth) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d4f7b16c2f
Assignee: nobody → joe
Target Milestone: --- → mozilla22
|
||
Comment 3•11 years ago
|
||
Backed out for build bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/3d81fc67e6ed
|
|
Assignee | |
Comment 4•11 years ago
|
||
I am terrible at programming. This depends on hanges in bug 716140, so I'm making this patch part <mumble> of that bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
|
|
||
Comment 5•11 years ago
|
||
Bummer. Bug 716140 has a lot of patches as it is!
You need to log in
before you can comment on or make changes to this bug.
Description
•