847634 - Duplicate Set of Tab Buttons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Brett W.]

Attachment: Screenshot of Duplicate Tab Icons

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130215130331

Steps to reproduce:

With a website loaded in a tab, I hit the tab counter in the top right. 

On Aurora 21.0a2 2013-03-04.


Actual results:

The top bar with icons delineating tabs, private tabs ans synced tabs has a duplicate set of identical buttons to the right which don't do anything. See screenshot attached.


Expected results:

Single set of icons should appear.

Comment 1

[Aaron Train [:aaronmt]]

Wild, havn't seen this. Sriram, any thoughts?

Brett, which phone is that?

Comment 2

[Brett W.]

Galaxy SII derivative: Samsung SPH-D710 (Epic 4G Touch) with Android 4.04.

Comment 4

[Matt Brubeck (:mbrubeck)]

Regression from bug 845511:
https://hg.mozilla.org/releases/mozilla-aurora/rev/d18a62362aab

The patches that landed on Aurora and Beta were incomplete, and did not remove the previous addTab calls:
https://hg.mozilla.org/releases/mozilla-aurora/rev/d18a62362aab#l1.34

Comment 6

[Brian Nicholson (:bnicholson)]

Attachment: Add lines missing from uplift

[Approval Request Comment]
Regression caused by (bug #): uplifting bug 845511; lines from m-c patch didn't make uplift
User impact if declined: duplicate tabs tray tabs (see screenshot)
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): very low risk

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 721119 [details] [diff] [review]
Add lines missing from uplift

Note to others: This patch should only be used on Aurora and Beta

Comment 8

[Scoobidiver (away)]

(In reply to Brian Nicholson (:bnicholson) from comment #6)
Uplift to Aurora instead of Release?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 721119 [details] [diff] [review]
Add lines missing from uplift

[Approval Request Comment]
See above

Comment 10

[Brian Nicholson (:bnicholson)]

Comment on attachment 721119 [details] [diff] [review]
Add lines missing from uplift

This was already approved and just adds the missing lines, so I'll land the fix now.

Comment 11

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c510ca6982d7

Comment 12

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-beta/rev/10be0f4a5eba

Comment 13

[Marco Zehe (:MarcoZ)]

Thanks for fixing this, and I am terribly sorry for the mess-up of that uplift!

Comment 15

[Adrian Tamas (:AdrianT)]

Unable to reproduce the issue on Aurora 21.0a2 2013-03-14 or Firefox Mobile 20 beta 5 on the Samsung Galaxy S2 (Android 4.0.3)