Closed
Bug 847634
Opened 11 years ago
Closed 11 years ago
Duplicate Set of Tab Buttons
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox20 verified, firefox21 verified, firefox22 unaffected)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
firefox20 | --- | verified |
firefox21 | --- | verified |
firefox22 | --- | unaffected |
People
(Reporter: nrbelex, Assigned: bnicholson)
References
Details
(Keywords: regression)
Attachments
(2 files)
44.96 KB,
image/png
|
Details | |
1.18 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0 Build ID: 20130215130331 Steps to reproduce: With a website loaded in a tab, I hit the tab counter in the top right. On Aurora 21.0a2 2013-03-04. Actual results: The top bar with icons delineating tabs, private tabs ans synced tabs has a duplicate set of identical buttons to the right which don't do anything. See screenshot attached. Expected results: Single set of icons should appear.
Comment 1•11 years ago
|
||
Wild, havn't seen this. Sriram, any thoughts? Brett, which phone is that?
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Galaxy SII derivative: Samsung SPH-D710 (Epic 4G Touch) with Android 4.04.
Updated•11 years ago
|
tracking-fennec: --- → ?
status-firefox21:
--- → affected
Comment 4•11 years ago
|
||
Regression from bug 845511: https://hg.mozilla.org/releases/mozilla-aurora/rev/d18a62362aab The patches that landed on Aurora and Beta were incomplete, and did not remove the previous addTab calls: https://hg.mozilla.org/releases/mozilla-aurora/rev/d18a62362aab#l1.34
Blocks: 845511
status-firefox20:
--- → affected
status-firefox22:
--- → unaffected
Keywords: regression
Updated•11 years ago
|
Version: Firefox 21 → Firefox 20
Assignee | ||
Comment 6•11 years ago
|
||
[Approval Request Comment] Regression caused by (bug #): uplifting bug 845511; lines from m-c patch didn't make uplift User impact if declined: duplicate tabs tray tabs (see screenshot) Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): very low risk
Assignee: nobody → bnicholson
Attachment #721119 -
Flags: review?(mark.finkle)
Attachment #721119 -
Flags: approval-mozilla-release?
Attachment #721119 -
Flags: approval-mozilla-beta?
Comment 7•11 years ago
|
||
Comment on attachment 721119 [details] [diff] [review] Add lines missing from uplift Note to others: This patch should only be used on Aurora and Beta
Attachment #721119 -
Flags: review?(mark.finkle) → review+
Comment 8•11 years ago
|
||
(In reply to Brian Nicholson (:bnicholson) from comment #6) Uplift to Aurora instead of Release?
Comment 9•11 years ago
|
||
Comment on attachment 721119 [details] [diff] [review] Add lines missing from uplift [Approval Request Comment] See above
Attachment #721119 -
Flags: approval-mozilla-release? → approval-mozilla-aurora?
Assignee | ||
Comment 10•11 years ago
|
||
Comment on attachment 721119 [details] [diff] [review] Add lines missing from uplift This was already approved and just adds the missing lines, so I'll land the fix now.
Attachment #721119 -
Flags: approval-mozilla-beta?
Attachment #721119 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c510ca6982d7
Assignee | ||
Comment 12•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/10be0f4a5eba
Comment 13•11 years ago
|
||
Thanks for fixing this, and I am terribly sorry for the mess-up of that uplift!
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 15•11 years ago
|
||
Unable to reproduce the issue on Aurora 21.0a2 2013-03-14 or Firefox Mobile 20 beta 5 on the Samsung Galaxy S2 (Android 4.0.3)
Updated•10 years ago
|
tracking-fennec: ? → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•