Closed
Bug 847639
Opened 11 years ago
Closed 11 years ago
Foxtrot with Write a Review page
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: cvan, Assigned: jfong)
References
()
Details
(Whiteboard: [fireplace] p=2)
Formerly https://github.com/mozilla/fireplace/issues/16 In Zamboni land: On desktop rating submission is a modal. On mobile we currently do a separate page/request. For Fireplace this should be matter of creating a nunjucks template that we can use in both places. On desktop it should open us a modal. On mobile it should render the template as a full-page overlay, if we can call it that. For anonymous users: Clicking on the "Write a Review" button should trigger Persona then proceed to show the review. (Related: bug 844081) For authenticated users: Clicking on the "Write a Review" button should open the overlay.
Reporter | ||
Updated•11 years ago
|
Summary: Foxtrotting with Write a Review page → Foxtrot with Write a Review page
Updated•11 years ago
|
Priority: -- → P2
Whiteboard: [fireplace] → [fireplace] p=2
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jfong
Assignee | ||
Comment 1•11 years ago
|
||
merged in https://github.com/mozilla/fireplace/commit/1c89949df25ae28dffc25fd4dd8a97de13740d48
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 2•11 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/ on FF24(Win 7) and MP-dev app on FF OS. Postfix screencast for anonymous users http://screencast.com/t/phwtCnhDxmx for authenticated users http://screencast.com/t/pGUr5gBB Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•