Add override for GetWrapperCache with smart pointer argument.

RESOLVED FIXED in mozilla22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: wchen, Assigned: wchen)

Tracking

unspecified
mozilla22
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
C++ reflections of WebIDL callback functions, when called with a smart pointer as the "this object," results in a compiler error due to ambiguity between GetWrapperCache(void* p) and GetWrapperCache(const ParentObject& aParentObject) in code generated by a few levels of templates.
(Assignee)

Comment 1

6 years ago
Created attachment 721037 [details] [diff] [review]
Added override for GetWrapperCache with smart pointer argument to resolve ambiguity in templates.
Attachment #721037 - Flags: review?(bzbarsky)
Comment on attachment 721037 [details] [diff] [review]
Added override for GetWrapperCache with smart pointer argument to resolve ambiguity in templates.

>+GetWrapperCache(SmartPtr<T> aObject)

Const ref, or at least ref, please?  We don't want to do extra refcounting here.

r=me with that.
Attachment #721037 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/3f464b187876
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.