Closed Bug 847804 Opened 9 years ago Closed 9 years ago

static assertion in SVGPreserveAspectRatio.h fails on systems where sizeof(bool) > char

Categories

(Core :: SVG, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: spectre, Assigned: spectre)

References

Details

Attachments

(1 file)

Per bug 826961 comment 10, remove the static assert since it has outlived its usefulness and causes build issues on platforms where sizeof(bool) > char (PowerPC, for example).
Assignee: nobody → spectre
Blocks: 826961
Attachment #721071 - Attachment is patch: true
Attachment #721071 - Flags: review?(dholbert)
Comment on attachment 721071 [details] [diff] [review]
Remove the static assert in SVGPreserveAspectRatio.h

># HG changeset patch
># User Cameron Kaiser <spectre@armory.com>
># Date 1362464873 28800
># Node ID 912984bb031edc39beda6608f7d7e57b354e6fc6
># Parent  9f18d05d1ba1f216ba7e4277315ffb912270548f
>Remove assert in SVGPreserveAspectRatio.h per bug 826961 comment 10

Probably worth massaging that commit message. :)

Maybe just:
  Bug 847804: Remove no-longer-important static assert in SVGPreserveAspectRatio.h. r=dholbert

...or something along those lines.

r=me, anyway - thanks!
Attachment #721071 - Flags: review?(dholbert) → review+
Summary: Assert in SVGPreserveAspectRatio.h fails on systems where sizeof(bool) > char → static assertion in SVGPreserveAspectRatio.h fails on systems where sizeof(bool) > char
Thanks for the r+ :) I'll throw myself at the mercy of checkin on the commit message, since I didn't have the bug number when I committed it internally.
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cc0537ee0094
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.