Remove browser.geolocation.warning.infoURL preference for b2g if it's not used

RESOLVED FIXED in 1.3 Sprint 5 - 11/22

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: raymondlee, Assigned: retornam)

Tracking

unspecified
1.3 Sprint 5 - 11/22
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Remove it if it's not used or change the url to Https://www.mozilla.org/...
I suggest we just change its value to https:// instead of removing it. Otherwise, it will likely just get added back sometime later as http:// and we'll have to file another bug to fix it.
(Assignee)

Comment 2

5 years ago
Created attachment 779314 [details] [diff] [review]
bug-847811.patch

I updated the url to https and to point directly to mozilla.org instead to mozilla.com ( mozilla.com redirects to mozilla.org now)
Attachment #779314 - Flags: review?(brian)
Comment on attachment 779314 [details] [diff] [review]
bug-847811.patch

Review of attachment 779314 [details] [diff] [review]:
-----------------------------------------------------------------

Gavin has been reviewing all of these and he knows all the special cases that I don't know, so punting this over to him.
Attachment #779314 - Flags: review?(brian) → review?(gavin.sharp)
Comment on attachment 779314 [details] [diff] [review]
bug-847811.patch

I think it's unlikely that these preferences would be used by the b2g browser at some later point, so I really would prefer just removing them.
Attachment #779314 - Flags: review?(gavin.sharp)
(Assignee)

Updated

5 years ago
Assignee: nobody → mozbugs.retornam
(Assignee)

Comment 5

5 years ago
Created attachment 783254 [details] [diff] [review]
bug-847811-fix.patch
Attachment #779314 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #783254 - Flags: review?(gavin.sharp)
Comment on attachment 783254 [details] [diff] [review]
bug-847811-fix.patch

Looks good to me, but you should get a b2g peer to review.
Attachment #783254 - Flags: review?(gavin.sharp) → feedback+
(Assignee)

Updated

5 years ago
Attachment #783254 - Flags: review?(fabrice)
Comment on attachment 783254 [details] [diff] [review]
bug-847811-fix.patch

Review of attachment 783254 [details] [diff] [review]:
-----------------------------------------------------------------

There's another instance of this pref at line 316 : https://mxr.mozilla.org/mozilla-central/search?string=browser.geolocation.warning.infoURL
Attachment #783254 - Flags: review?(fabrice) → review-
(Assignee)

Comment 8

5 years ago
Created attachment 785161 [details] [diff] [review]
bug-847811.patch
Attachment #783254 - Attachment is obsolete: true
Attachment #785161 - Flags: review?(fabrice)
Attachment #785161 - Flags: review?(fabrice) → review+
If you need something landed, please use checkin-needed instead of just CCing me without comment.
Keywords: checkin-needed
(Assignee)

Comment 10

5 years ago
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #9)
> If you need something landed, please use checkin-needed instead of just
> CCing me without comment.

Thanks Ryan. I'll do that next time.
https://hg.mozilla.org/mozilla-central/rev/585ff8eb2be7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 5 - 11/22
You need to log in before you can comment on or make changes to this bug.