Closed Bug 847811 Opened 11 years ago Closed 10 years ago

Remove browser.geolocation.warning.infoURL preference for b2g if it's not used

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 5 - 11/22

People

(Reporter: raymondlee, Assigned: retornam)

References

Details

Attachments

(1 file, 2 obsolete files)

bug-847811.patch
963 bytes, patch
fabrice
: review+
Details | Diff | Splinter Review 
Remove it if it's not used or change the url to Https://www.mozilla.org/...
I suggest we just change its value to https:// instead of removing it. Otherwise, it will likely just get added back sometime later as http:// and we'll have to file another bug to fix it.
Attached patch bug-847811.patch (obsolete) — — Splinter Review 
I updated the url to https and to point directly to mozilla.org instead to mozilla.com ( mozilla.com redirects to mozilla.org now)
Attachment #779314 - Flags: review?(brian)
Comment on attachment 779314 [details] [diff] [review]
bug-847811.patch

Review of attachment 779314 [details] [diff] [review]:
-----------------------------------------------------------------

Gavin has been reviewing all of these and he knows all the special cases that I don't know, so punting this over to him.
Attachment #779314 - Flags: review?(brian) → review?(gavin.sharp)
Comment on attachment 779314 [details] [diff] [review]
bug-847811.patch

I think it's unlikely that these preferences would be used by the b2g browser at some later point, so I really would prefer just removing them.
Attachment #779314 - Flags: review?(gavin.sharp)
Assignee: nobody → mozbugs.retornam
Attached patch bug-847811-fix.patch (obsolete) — — Splinter Review 

        Attachment #779314 -
        Attachment is obsolete: true

    
  

        Attachment #783254 -
        Flags: review?(gavin.sharp)

    
    

    
  
Comment on attachment 783254 [details] [diff] [review]
bug-847811-fix.patch

Looks good to me, but you should get a b2g peer to review.

        Attachment #783254 -
        Flags: review?(gavin.sharp) → feedback+

    
  

        Attachment #783254 -
        Flags: review?(fabrice)

    
    

    
  
Comment on attachment 783254 [details] [diff] [review]
bug-847811-fix.patch

Review of attachment 783254 [details] [diff] [review]:
-----------------------------------------------------------------

There's another instance of this pref at line 316 : https://mxr.mozilla.org/mozilla-central/search?string=browser.geolocation.warning.infoURL

        Attachment #783254 -
        Flags: review?(fabrice) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug-847811.patch
        — 
          — Splinter Review
      

    


  

        Attachment #783254 -
        Attachment is obsolete: true

        Attachment #785161 -
        Flags: review?(fabrice)

        Attachment #785161 -
        Flags: review?(fabrice) → review+

    
    

    
  
If you need something landed, please use checkin-needed instead of just CCing me without comment.
Keywords: checkin-needed

    
    

    
  
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #9)
> If you need something landed, please use checkin-needed instead of just
> CCing me without comment.

Thanks Ryan. I'll do that next time.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/585ff8eb2be7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 5 - 11/22

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: