847846 - Failures in test addons aren't correctly handled by tinderbox

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

For some reason, when a test fail in test addons, tinderbox parser fails to identify the failing test:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20333281&tree=Jetpack

The following message isn't detected by the log parser:
  error: private-browsing-supported: fail: Correct active window [1]

I just noticied that test addons are not in verbose mode, can it be because of that?

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 834

It appears that --parseable option is ignored for cfx testaddons and the related cfx run command that is executed in each test addon folder.
Here is a patch to allow this option in both cases so that cfx testall --parseable end up propagating --parsable option in all sub-commands being launched.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/834/files

Pointer to Github pull-request

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 722554 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/834/files

Oops

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/905e0bdb2c92e9a59fa701da37734e4f137936d9
Bug 847846: Accept --parseable option for test addons.

https://github.com/mozilla/addon-sdk/commit/dfe00dcc4a06e3a9621cff7d5dcc5aa7f8698084
Merge pull request #834 from ochameau/test-addons-parseable

Bug 847846: Accept --parseable option for test addons. r=@mossop

Comment 5

[[github robot]]

Commits pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/905e0bdb2c92e9a59fa701da37734e4f137936d9
Bug 847846: Accept --parseable option for test addons.

https://github.com/mozilla/addon-sdk/commit/dfe00dcc4a06e3a9621cff7d5dcc5aa7f8698084
Merge pull request #834 from ochameau/test-addons-parseable