847881 - test_sizetocontent_clamp.html fails on win8

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20302524&tree=Cedar&full=1#error0

ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_sizetocontent_clamp.html | innerWidth should be around 100

both debug and opt builds.

Comment 1

[Jim Mathies [:jimm]]

The smallest inner window width win8 allows is 122 pixels due to window chrome.

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix for win8

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 721206 [details] [diff] [review]
fix for win8

Review of attachment 721206 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the requested change

::: dom/tests/mochitest/bugs/test_sizetocontent_clamp.html
@@ +33,5 @@
>  // requested.
>  var epsilon =  navigator.platform.indexOf("Win") == -1 ? 5 : 20;
>  
> +// Update: Windows 8 has a minimum 122 pixel inner window width due to outer window chrome.
> +var isWin8 = (navigator.userAgent.indexOf("Windows NT 6.2") != -1);

nit: no need for the parenthesis

@@ +49,5 @@
>        }
>  
> +      if (isWin8) {
> +        ok(w.innerWidth >= 120 && w.innerWidth <= 125,
> +           "innerWidth should be around 122");

I would prefer you had something like:

var expectedWidth = isWin8 ? 125 : 120;
var expectedHeight = 100;

ok(w.innerWidth + epsilon >= expectedWidth && [...]);
ok([...]);

Comment 4

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41efbfe49d66

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/41efbfe49d66