847916 - Reduce logging in robocop testBrowserProvider

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

testBrowserProvider's assertions dominate the robocop logs, making them unwieldy. I would like to reduce the logging, especially these:

106 INFO TEST-PASS | testBrowserProvider - TestPositionBookmarks | Position matches sequence. - 0 should equal 0
107 INFO TEST-PASS | testBrowserProvider - TestPositionBookmarks | GUID matches sequence. - aaaaaaaaaaa0 should equal aaaaaaaaaaa0
108 INFO TEST-PASS | testBrowserProvider - TestPositionBookmarks | Position matches sequence. - 1 should equal 1
109 INFO TEST-PASS | testBrowserProvider - TestPositionBookmarks | GUID matches sequence. - aaaaaaaaaaa1 should equal aaaaaaaaaaa1
...
4110 INFO TEST-PASS | testBrowserProvider - TestPositionBookmarks | GUID matches sequence. - aaaaaaaaa786 should equal aaaaaaaaa786
4111 INFO TEST-PASS | testBrowserProvider - TestPositionBookmarks | Position matches sequence. - 1000 should equal 1000
4112 INFO TEST-PASS | testBrowserProvider - TestPositionBookmarks | GUID matches sequence. - aaaaaaaaaa92 should equal aaaaaaaaaa92

Comment 1

[Geoff Brown [:gbrown]]

Attachment: only assert on failure for very-common assertion in loop

You can see the reduced log at https://tbpl.mozilla.org/php/getParsedLog.php?id=20339802&tree=Try&full=1. This seems easier to scan visually.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 721218 [details] [diff] [review]
only assert on failure for very-common assertion in loop

Review of attachment 721218 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tests/testBrowserProvider.java.in
@@ +941,5 @@
>  
>              while (!c.isAfterLast()) {
>                  String guid = c.getString(guidColumn);
>                  long pos = c.getLong(posColumn);
> +                if ((pos != i) || (!guid.equals(items[i]))) {

Add 

  (guid == null) ||

between the two checks. If the cursor is returning a null GUID, that's something we want to fall through to the assertion, and save ourselves a NPE.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: only assert on failure for very-common assertion in loop

Updated for review comment -- thanks!

Comment 4

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e2ca4139f64

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0e2ca4139f64