847918 - `install` command for mach

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Paul Adenot (:padenot)]

Basically a mach command to install an apk on a device, in the same fashion as `package`.

Comment 1

[Paul Adenot (:padenot)]

Attachment: `install` command for mach. r=

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 721219 [details] [diff] [review]
`install` command for mach. r=

Review of attachment 721219 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +279,5 @@
> +@CommandProvider
> +class Install(MachCommandBase):
> +    """Install a package on a device."""
> +
> +    @Command('install', help='Install a .apk package on an Android device.')

Needs a better message. make install is not Android-specific.

Comment 3

[Paul Adenot (:padenot)]

Attachment: `install` command for mach. r=

Right. For some reason I forgot about that.

I'm probably the worst person to word things correctly, though, feel free to
propose alternatives.

Comment 4

[Nick Alexander :nalexander [he/him]]

This is equivalent to `mach build install`.  Are we concerned about duplication?  We might have `mach foo` search Makefiles and see if `mach build foo` is sensible.

Comment 5

[(not currently active) Ted Mielczarek]

I don't think that's an issue. Having first-level commands for common tasks feels like the right thing to do.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 721267 [details] [diff] [review]
`install` command for mach. r=

Review of attachment 721267 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +281,5 @@
> +    """Install a package."""
> +
> +    @Command('install', help='Install the package on the machine, or on a device.')
> +    def install(self):
> +        self._run_make(directory=".", target='install', ensure_exit_code=False)

Please return the result of this function (the exit code of make).

Comment 7

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/159e6f0fc37c

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/159e6f0fc37c