Closed Bug 847918 Opened 9 years ago Closed 9 years ago

`install` command for mach

Categories

(Firefox Build System :: Mach Core, enhancement)

x86_64
Linux
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(1 file, 1 obsolete file)

Basically a mach command to install an apk on a device, in the same fashion as `package`.
Attached patch `install` command for mach. r= (obsolete) — Splinter Review
Attachment #721219 - Flags: review?(gps)
Comment on attachment 721219 [details] [diff] [review]
`install` command for mach. r=

Review of attachment 721219 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +279,5 @@
> +@CommandProvider
> +class Install(MachCommandBase):
> +    """Install a package on a device."""
> +
> +    @Command('install', help='Install a .apk package on an Android device.')

Needs a better message. make install is not Android-specific.
Right. For some reason I forgot about that.

I'm probably the worst person to word things correctly, though, feel free to
propose alternatives.
Attachment #721267 - Flags: review?(gps)
Attachment #721219 - Attachment is obsolete: true
Attachment #721219 - Flags: review?(gps)
This is equivalent to `mach build install`.  Are we concerned about duplication?  We might have `mach foo` search Makefiles and see if `mach build foo` is sensible.
I don't think that's an issue. Having first-level commands for common tasks feels like the right thing to do.
Comment on attachment 721267 [details] [diff] [review]
`install` command for mach. r=

Review of attachment 721267 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +281,5 @@
> +    """Install a package."""
> +
> +    @Command('install', help='Install the package on the machine, or on a device.')
> +    def install(self):
> +        self._run_make(directory=".", target='install', ensure_exit_code=False)

Please return the result of this function (the exit code of make).
Attachment #721267 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/159e6f0fc37c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.