Closed Bug 847928 Opened 9 years ago Closed 9 years ago
Element type of a Web
IDL array must not be a sequence or dictionary type .
http://dev.w3.org/2006/webapi/WebIDL/#idl-array The spec details that an array type must not contain a dictionary or sequence as its element type. This needs to be implemented in the WebIDL parser.
Attachment #721233 - Flags: feedback?(bzbarsky)
Comment on attachment 721233 [details] [diff] [review] Possible patch > + assert not self.isDictionary() Why? Nothing prevents that. This should be a WebIDLError, not an assert. What's the actual exception thrown in your test here? Further, I think you should be testing self.inner.isDictionary(), not self.isDictionary(). If self.isDictionary() ever returns true for an IDLArrayType, that's just broken.
Attachment #721233 - Flags: feedback?(bzbarsky) → feedback+
Here's the WebIDLError raised: error: Array type must not contain dictionary as element type., <unknown> line 7:12 Foo b; ^
Comment on attachment 721321 [details] [diff] [review] Patch v2 Looks great. Please put the bug number and reviewer in your commit message, though.
Comment on attachment 721329 [details] [diff] [review] Patch v3 r=me
Attachment #721329 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.