847928 - Element type of a WebIDL array must not be a sequence or dictionary type.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Pranav Ravichandran [:pranavrc]]

Attachment: Possible patch

http://dev.w3.org/2006/webapi/WebIDL/#idl-array

The spec details that an array type must not contain a dictionary or sequence as its element type. This needs to be implemented in the WebIDL parser.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 721233 [details] [diff] [review]
Possible patch

> +        assert not self.isDictionary()

Why?  Nothing prevents that.  This should be a WebIDLError, not an assert.  What's the actual exception thrown in your test here?

Further, I think you should be testing self.inner.isDictionary(), not self.isDictionary().  If self.isDictionary() ever returns true for an IDLArrayType, that's just broken.

Comment 2

[Pranav Ravichandran [:pranavrc]]

Attachment: Patch v2

Here's the WebIDLError raised:

error: Array type must not contain dictionary as element type., <unknown> line 7:12
            Foo[] b;
            ^

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 721321 [details] [diff] [review]
Patch v2

Looks great.  Please put the bug number and reviewer in your commit message, though.

Comment 4

[Pranav Ravichandran [:pranavrc]]

Attachment: Patch v3

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 721329 [details] [diff] [review]
Patch v3

r=me

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ddf8cdc9d2e3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ddf8cdc9d2e3