Closed Bug 847942 Opened 7 years ago Closed 7 years ago

Make active tap highlight color gray instead of orange

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 22

People

(Reporter: Margaret, Assigned: Margaret)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Ian decided that we've gone a bit overboard on the orange, so we're going to scale back on the active tap highlight color.

I used a color Ian gave me, but maybe there's a system color we should use? I'm not sure if that exists or not.
Attachment #721252 - Flags: review?(wjohnston)
I like 173,225,245 from the system UI on 4.2
Assignee: nobody → margaret.leibovic
Attachment #721252 - Flags: review?(wjohnston) → review+
Ian, how do you feel about Aaron's suggestion? Should we stick with rgba(171, 171, 171, 0.5), or do you want to update that?
Flags: needinfo?(ibarlow)
I'd like to make everything grey. This ties into work happening to make all the selection colours in the UI neutral (see bug 848707)
Flags: needinfo?(ibarlow)
Thanks for the feedback. I pushed the patch with the gray.

https://hg.mozilla.org/integration/mozilla-inbound/rev/edff7aaa5e65
https://hg.mozilla.org/mozilla-central/rev/edff7aaa5e65
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.