Closed
Bug 847942
Opened 11 years ago
Closed 11 years ago
Make active tap highlight color gray instead of orange
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: Margaret, Assigned: Margaret)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
Ian decided that we've gone a bit overboard on the orange, so we're going to scale back on the active tap highlight color. I used a color Ian gave me, but maybe there's a system color we should use? I'm not sure if that exists or not.
Attachment #721252 -
Flags: review?(wjohnston)
|
||
Comment 1•11 years ago
|
||
I like 173,225,245 from the system UI on 4.2
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → margaret.leibovic
|
||
Updated•11 years ago
|
Attachment #721252 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Ian, how do you feel about Aaron's suggestion? Should we stick with rgba(171, 171, 171, 0.5), or do you want to update that?
Flags: needinfo?(ibarlow)
|
||
Comment 3•11 years ago
|
||
I'd like to make everything grey. This ties into work happening to make all the selection colours in the UI neutral (see bug 848707)
Flags: needinfo?(ibarlow)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Thanks for the feedback. I pushed the patch with the gray. https://hg.mozilla.org/integration/mozilla-inbound/rev/edff7aaa5e65
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/edff7aaa5e65
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•