847971 - contentAreaUtils's openURL should restrict its recent window search to windows of the same privacy status

Status: NEW

(Toolkit :: General, defect)

Comment 1

[Josh Matthews [:jdm]]

Attachment: Make openURL select recent windows that match the current privacy state.

Comment 2

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f85e650c1df7

Comment 3

[Josh Matthews [:jdm]]

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c9fcfd9f4ce
Bad interaction with other patches I pushed.

Comment 4

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f029edccac09

Comment 5

[Dão Gottwald [:dao]]

(In reply to Josh Matthews [:jdm] from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f029edccac09

I backed this out; this patch makes openURL call RecentWindow.getMostRecentWindow, which doesn't exist.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6678ea192a6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/867475abb894

Comment 6

[Ed Morley [:emorley]]

Which causes these timeouts:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20781373&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20781208&tree=Mozilla-Inbound
etc

Comment 7

[Ed Morley [:emorley]]

Also assertions in the form of:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20780447&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20781393&tree=Mozilla-Inbound

Comment 8

[Justin Dolske [:Dolske]]

(In reply to Dão Gottwald [:dao] from comment #5)
 
> I backed this out; this patch makes openURL call
> RecentWindow.getMostRecentWindow, which doesn't exist.

Was this patch simply never tested, or was this a snafu with renaming the function in another patch?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Earlier patches for bug 847952 added getMostRecentWindow, I assume this patch was built on top of that one.