Closed Bug 847973 Opened 7 years ago Closed 6 years ago
Support ASan builds and tests in trychooser
Right now, to get a try run with ASan, people need to copy the ASan configs (which are in the tree) over the regular configs before pushing. It would be good to allow ASan runs (for linux64 only) natively as an option in the trychooser. That way it's also easier for people to explicitly check that they don't break that build type which happened quite a few times before.
Product: mozilla.org → Release Engineering
per meeting with decoder, clarifying that this is for ASan builds *and* tests. Also noting that these should be non-default on try. Only people who actually care about ASan builds/tests will specifically ask for them.
Component: General Automation → Tools
QA Contact: catlee → hwine
Summary: Support ASan in trychooser → Support ASan builds and tests in trychooser
I'm not sure how this is going to be implemented in trychooser, but I assume it would be another platform (e.g. linux64-asan). There is no new test suite added, instead the tests that we can currently run on ASan are: reftest, crashtest, xpcshell, jsreftest, mochitests
6 years ago
Yeah, there's nothing in the way of interest or decisions in trychooser, nor is there much of anything to patch, a few dozen copy-pasted characters. What's needed is: * bug 887641 renaming the debug build so that the try syntax parser would know it was a debug build rather than an oddly-named opt build (landed, but not in production yet) * giving the debug build TRY_SLAVES, since for some reason http://hg.mozilla.org/build/buildbot-configs/file/1bcd9ace6472/mozilla/config.py#l1902 did opt but not debug * sticking try back into http://hg.mozilla.org/build/buildbot-configs/file/1bcd9ace6472/mozilla/config.py#l2056 where it was removed because we panicked about whether or not try_by_default actually worked at which point doing -b do -p linux64-asan -u none (or all, but there won't be any) -t none will give you opt and debug builds - the tests come for free once bug 831491 makes them exist, so this depends on that rather than blocking that, and then it's a two minute patch to the trychooser web page.
For reasons beyond my ken, I still can't persuade test-masters.sh (or setup-master.py, or dump_master.py) to run, but surely this won't break anything, will it?
Comment on attachment 796454 [details] [diff] [review] [configs] let it build Beaten out by attachment 797416 [details] [diff] [review].
Comment on attachment 799945 [details] [diff] [review] [tools] Add linux64-asan Review of attachment 799945 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for doing these :-)
Attachment #799945 - Flags: review?(emorley) → review+
http://hg.mozilla.org/build/tools/rev/beb959b60583 And deployed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.