848026 - Debugging information of Cost Control is being displayed on v1-train

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

DEBUGGING flag is set to true on v1-train

Comment 1

[Salvador de la Puente González [:salva]]

Attachment: Disabling DEBUGGING flag on v1-train

Please note this PR is only for v1-train.

Comment 2

[Alex Keybl [:akeybl]]

Actually, I'd like to see this play out on the thread - engineering/QA use this flag.

Comment 3

[Alex Keybl [:akeybl]]

I emailed:

"I think it may be OK in v1-train as well, as long as this is never enabled in a final release or during perf testing. Most of the consumers of v1-train/mozilla-b2g18 builds are QA and engineers, so it makes sense to have debugging enabled by default in my opinion. If we do swap the default value, we need to make sure this value is still enabled in all internal builds."

Comment 4

[Salvador de la Puente González [:salva]]

No, I think is better to keep it disabled as debugging degrades performance.

Comment 5

[Alex Keybl [:akeybl]]

I now see that this DEBUGGING flag is specific to cost control, so I don't have any objection.

Comment 6

[Salvador de la Puente González [:salva]]

Thanks Alex!

Comment 7

[Salvador de la Puente González [:salva]]

v1-train: fa5245750e7bb94b9f64180967536509316dedf5