Debugging information of Cost Control is being displayed on v1-train

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: salva, Assigned: salva)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(b2g18+ fixed)

Details

Attachments

(1 attachment)

DEBUGGING flag is set to true on v1-train
Created attachment 721348 [details]
Disabling DEBUGGING flag on v1-train

Please note this PR is only for v1-train.
Attachment #721348 - Flags: review?(21)

Updated

6 years ago
tracking-b2g18: ? → +

Comment 2

6 years ago
Actually, I'd like to see this play out on the thread - engineering/QA use this flag.
tracking-b2g18: + → ?

Comment 3

6 years ago
I emailed:

"I think it may be OK in v1-train as well, as long as this is never enabled in a final release or during perf testing. Most of the consumers of v1-train/mozilla-b2g18 builds are QA and engineers, so it makes sense to have debugging enabled by default in my opinion. If we do swap the default value, we need to make sure this value is still enabled in all internal builds."
No, I think is better to keep it disabled as debugging degrades performance.

Comment 5

6 years ago
I now see that this DEBUGGING flag is specific to cost control, so I don't have any objection.
tracking-b2g18: ? → +
Thanks Alex!
v1-train: fa5245750e7bb94b9f64180967536509316dedf5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
status-b2g18: --- → fixed
You need to log in before you can comment on or make changes to this bug.