Move poisoning after NS_XPCOM_SHUTDOWN_LOADERS_OBSERVER_ID

RESOLVED FIXED in mozilla22

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla22
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 721349 [details] [diff] [review]
patch

Write poisoning found this:

mozilla::patched_FlushBuffersFile(void *,_IO_STATUS_BLOCK *) (in xul.pdb)
FlushFileBuffersImplementation (in wkernel32.pdb)
winSync (in mozsqlite3.pdb)
`anonymous namespace'::xSync(sqlite3_file *,int) (in xul.pdb)
walCheckpoint (in mozsqlite3.pdb)
sqlite3WalCheckpoint (in mozsqlite3.pdb)
sqlite3BtreeClose (in mozsqlite3.pdb)
sqlite3LeaveMutexAndCloseZombie (in mozsqlite3.pdb)
sqlite3Close (in mozsqlite3.pdb)
sqlite3_close (in mozsqlite3.pdb)
mozilla::storage::Connection::internalClose() (in xul.pdb)
mozilla::storage::Connection::~Connection() (in xul.pdb)
nsCOMPtr<nsIRDFNode>::`scalar deleting destructor'(unsigned int) (in xul.pdb)
nsTArray_Impl<nsRefPtr<mozilla::a11y::Accessible>,nsTArrayInfallibleAllocator>::DestructRange(unsigned int,unsigned int) (in xul.pdb)
nsTArray_Impl<nsRefPtr<imgRequestProxy>,nsTArrayInfallibleAllocator>::RemoveElementsAt(unsigned int,unsigned int) (in xul.pdb)
nsTArray_Impl<nsRefPtr<mozilla::a11y::DocAccessible>,nsTArrayInfallibleAllocator>::RemoveElement<mozilla::a11y::DocAccessible *,nsDefaultComparator<nsRefPtr<mozilla::a11y::DocAccessible>,mozilla::a11y::D
ocAccessible *> >(mozilla::a11y::DocAccessible * const &,nsDefaultComparator<nsRefPtr<mozilla::a11y::DocAccessible>,mozilla::a11y::DocAccessible *> const &) (in xul.pdb)
mozilla::storage::Service::unregisterConnection(mozilla::storage::Connection *) (in xul.pdb)
mozilla::storage::Connection::Release() (in xul.pdb)
mozilla::storage::Statement::~Statement() (in xul.pdb)
DoDeferredRelease<nsISupports *> (in xul.pdb)
XPCJSRuntime::GCCallback(JSRuntime *,JSGCStatus) (in xul.pdb)
Collect (in mozjs.pdb)
js::GC(JSRuntime *,js::JSGCInvocationKind,JS::gcreason::Reason) (in mozjs.pdb)
js::DestroyContext(JSContext *,js::DestroyContextMode) (in mozjs.pdb)
JS_DestroyContext(JSContext *) (in mozjs.pdb)
mozJSComponentLoader::UnloadModules() (in xul.pdb)
mozJSComponentLoader::Observe(nsISupports *,char const *,wchar_t const *) (in xul.pdb)
mozilla::ShutdownXPCOM(nsIServiceManager *) (in xul.pdb)
ScopedXPCOMStartup::~ScopedXPCOMStartup() (in xul.pdb)
XREMain::XRE_main(int,char * * const,nsXREAppData const *) (in xul.pdb)
XRE_main (in xul.pdb)
do_main (in firefox.pdb)
wmain (in firefox.pdb)
__tmainCRTStartup (in firefox.pdb)
BaseThreadInitThunk (in wkernel32.pdb)
__RtlUserThreadStart (in wntdll.pdb)
_RtlUserThreadStart (in wntdll.pdb)


So this patch moves the write poisoning after NS_XPCOM_SHUTDOWN_LOADERS_OBSERVER_ID and moves the misplaced comment about sqlite.
Attachment #721349 - Flags: review?(bgirard)

Updated

5 years ago
Attachment #721349 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b5c5fcf2ea4
https://hg.mozilla.org/mozilla-central/rev/2b5c5fcf2ea4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.