848070 - Crash org.mozilla.gecko.TabsPanel.<init>(TabsPanel.java:84)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Daniel]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130303 Firefox/22.0
Build ID: 20130303030835

Steps to reproduce:

Some week ago Nightly stopped working on my Xperia Neo. When I launch the app the screen goes white and stays that way. I'm using a Nightly from 2013-03-04 and I'm running Android 4.0.4.

Comment 1

[Aaron Train [:aaronmt]]

Can you capture and attach to this bug some logcat output capturing the sequence of events when you launch Firefox?

Comment 2

[Daniel]

Attachment: Logcat log captured while trying to start Firefox

I recorded a log with the aLogcat app. Please tell me if it's not sufficient and I will gladly provide more information.

Comment 3

[Aaron Train [:aaronmt]]

E/GeckoViewsFactory(  334): Unable to instantiate view org.mozilla.gecko.TabsTray
E/GeckoViewsFactory(  334): java.lang.reflect.InvocationTargetException
E/GeckoViewsFactory(  334): 	at java.lang.reflect.Constructor.constructNative(Native Method)
E/GeckoViewsFactory(  334): 	at java.lang.reflect.Constructor.newInstance(Constructor.java:417)
E/GeckoViewsFactory(  334): 	at org.mozilla.gecko.GeckoViewsFactory.onCreateView(GeckoViewsFactory.java:105)
E/GeckoViewsFactory(  334): 	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:669)

Comment 5

[Aaron Train [:aaronmt]]

We should get a fix in so we dont lose more Nightly testers

Comment 6

[Lucas Rocha (:lucasr)]

I have a tentative fix for this bug. Could anyone with an affected xperia device try this test build and let me know if it crashes on startup?

  https://dl.dropbox.com/u/1187037/xperia-fix.apk

Comment 7

[Aaron Train [:aaronmt]]

Daniel, would you be able to test out the above package? It's an unbranded version of Fennec that contains a tentative fix.

Comment 8

[Daniel]

Attachment: Logcat for tentative fix

Sorry, it didn't work :/ The symptoms are the same as before. I've attached a new logcat if it is of any help.

Comment 9

[Lucas Rocha (:lucasr)]

Hey Daniel, could you try this one and let me know if it works?

  https://dl.dropbox.com/u/1187037/xperia-fix-2.apk

Comment 10

[Lucas Rocha (:lucasr)]

Sorry, this is the correct apk:

  https://dl.dropbox.com/u/1187037/xperia-fix-3.apk

Comment 11

[Aaron Train [:aaronmt]]

Nightly: https://appthwack.com/public/ieDbm92rla (Failures)
xperia-fix-3: https://appthwack.com/public/FScl0s72eu (Green)

The above build seems to do the trick.

Comment 12

[Lucas Rocha (:lucasr)]

Attachment: Import View attributes to TwoWayView

It seems we can't rely on having stable ids on Android's built-in style attributes. It seems that on some xperia phones some attribute ids are higher than the size of style attributes declared in TwoWayView, causing that ArrayOutOfBounds exception.

We have to explicitly declare all View style attributes in TwoWayView to ensure this is never going to happen.

Aaron just verified that the patch works on the affected devices.

Comment 13

[Daniel]

(In reply to Lucas Rocha (:lucasr) from comment #10)
> Sorry, this is the correct apk:
> 
>   https://dl.dropbox.com/u/1187037/xperia-fix-3.apk

It does work indeed. Great job!

Comment 14

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ac609be0e139

Comment 15

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ac609be0e139