Closed Bug 848085 Opened 9 years ago Closed 9 years ago

Add telemetry probe for session file createBackupCopy.

Categories

(Firefox :: Session Restore, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 22

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(1 file, 3 obsolete files)

Currently there is no telemetry data being collected for createBackupCopy inside _SessionFile.jsm.

In order to assess future improvements to this functionality we need to collect some performance data beforehand.
Assignee: nobody → yura.zenevich
Blocks: 833286
Comment on attachment 721437 [details] [diff] [review]
Adding telemetry probe to session file backup copy.

Review of attachment 721437 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, this is going to be a little more complicated (see bug 848278).
Even trivial sub-bugs can have non-trivial sub-bugs :)
Attachment #721437 - Flags: review?(dteller)
Keeping this patch up to date with latest changes to Bug 848278.
Attachment #721437 - Attachment is obsolete: true
Attachment #723461 - Flags: review?(dteller)
Comment on attachment 723461 [details] [diff] [review]
Patch updated to changes from Bug 848278.

Review of attachment 723461 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #723461 - Flags: review?(dteller) → review+
Added an additional check for |outExecutionDuration| being numeric before adding to histogram.

Carrying forward r+ from Yoric.
Attachment #723461 - Attachment is obsolete: true
Carrying forward r+ from Yoric.
Attachment #725719 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d72d29f6a92c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.