Open Bug 848094 Opened 11 years ago Updated 2 years ago

ice_unittest should verify that DNS-resolution for STUN works.

Categories

(Core :: WebRTC: Networking, defect)

Product:
Core
Component:
WebRTC: Networking
Type:
defect

Tracking

()

Blocking Flags:
backlog parking-lot

People

(Reporter: jib, Unassigned)

References

Details

From Bug 837919, Comment 30:
>@@ +430,5 @@
>> +
>> +TEST_F(IceGatherTest, TestGatherDNSStunBogusHostname) {
>> +  peer_->SetStunServer(kBogusStunServerHostname, kDefaultStunServerPort);
>> +  peer_->SetDNSResolver();
>> +  Gather();
>
>These tests need to verify that the actual results make sense. Please file a bug.
Also:
>> +                                         nsIDNSService::RESOLVE_DISABLE_IPV6,
>> +                                         pr, my_NS_GetCurrentThread(),
>> +                                         getter_AddRefs(pr->request_)))) {
>
> [...] Please add a unit test that verifies that nICEr behaves properly in
> response to this. Suggest extending NrIceResolverFake
Whiteboard: [WebRTC][blocking-webrtc-]
backlog: --- → parking-lot
Whiteboard: [WebRTC][blocking-webrtc-]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.