Closed Bug 848117 Opened 13 years ago Closed 11 years ago

Use X-Sendfile to serve review comment attachments

Categories

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Product:
Marketplace Graveyard
Component:
Reviewer Tools
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: chuck, Assigned: chuck)

Details

(Whiteboard: p=1)

In the code about to land for #833497, we are directly serving the contents of the file attachment to the user via Content-Type: application/force-download. Instead we should be using the X-SendFile header via HttpResponseSendFile, making nginx do all the work.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.