Closed Bug 848133 Opened 7 years ago Closed 7 years ago

wrapper.js in the system app has all sorts of code that tries to work with null and throws exceptions

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

Early enough in startup, WindowManager.getDisplayedApp and hence currentAppFrame return null.
Blocks: 844169
Attached patch Proposed patch (obsolete) — Splinter Review
I audited the other callsites in this file, and they seem to be ok.
Assignee: nobody → bzbarsky
Attachment #721537 - Flags: review?(fabrice)
Whiteboard: [need review]
Attachment #721537 - Attachment is obsolete: true
Attachment #721537 - Flags: review?(fabrice)
Attachment #721538 - Flags: review?(fabrice)
Comment on attachment 721538 [details] [diff] [review]
Proposed patch for real

Review of attachment 721538 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Boris!
Attachment #721538 - Flags: review?(fabrice) → review+
pushed on master: https://github.com/mozilla-b2g/gaia/commit/02bfa04be6b4996b2893b5a7a247ef837ac355a8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
ahal, how do I find out once this has propagated to the gaia that try uses?
Flags: needinfo?(ahalberstadt)
Whiteboard: [need review]
(In reply to Boris Zbarsky (:bz) from comment #5)
> ahal, how do I find out once this has propagated to the gaia that try uses?

We have to manually request that the emulator be updated by filing a bug under mozilla.org/Release Engineering.

Unfortunately, this is blocked by bug 843893, so we can't update the emulator's gaia until that bug is fixed.
Flags: needinfo?(ahalberstadt)
Depends on: 843893
You need to log in before you can comment on or make changes to this bug.