848133 - wrapper.js in the system app has all sorts of code that tries to work with null and throws exceptions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Early enough in startup, WindowManager.getDisplayedApp and hence currentAppFrame return null.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

I audited the other callsites in this file, and they seem to be ok.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch for real

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 721538 [details] [diff] [review]
Proposed patch for real

Review of attachment 721538 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Boris!

Comment 4

[[:fabrice] Fabrice Desré]

pushed on master: https://github.com/mozilla-b2g/gaia/commit/02bfa04be6b4996b2893b5a7a247ef837ac355a8

Comment 5

[Boris Zbarsky [:bzbarsky]]

ahal, how do I find out once this has propagated to the gaia that try uses?

Comment 6

[Jonathan Griffin (:jgriffin)]

(In reply to Boris Zbarsky (:bz) from comment #5)
> ahal, how do I find out once this has propagated to the gaia that try uses?

We have to manually request that the emulator be updated by filing a bug under mozilla.org/Release Engineering.

Unfortunately, this is blocked by bug 843893, so we can't update the emulator's gaia until that bug is fixed.