Do not need to SkipRoot inline assembler buffers

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla25
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Inline assembler buffers contain GC pointers that we do not want to poison, but there should be no need to SkipRoot them because GC should be suppressed when these buffers are being used. This suppression was broken but fixed in bug 846590.
Created attachment 721479 [details] [diff] [review]
Do not need to SkipRoot inline assembler buffers

I will send this to try before requesting review.
Depends on: 846590
Blocks: 813244
Comment on attachment 721479 [details] [diff] [review]
Do not need to SkipRoot inline assembler buffers

(Cleaning out my queues)

Happy on try: https://tbpl.mozilla.org/?tree=Try&rev=6f6bef556ae9
Attachment #721479 - Flags: review?(terrence)
Comment on attachment 721479 [details] [diff] [review]
Do not need to SkipRoot inline assembler buffers

Review of attachment 721479 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #721479 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/e12f7eb2b997
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.