848173 - Further WebRTC logging tweaks

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Adam Roach [:abr]]

I've been running with this patch locally to help speed up finding where
log messages have been emitted, and found it quite useful.

Comment 1

[Adam Roach [:abr]]

Attachment: Include filenames in WebRTC log messages

Comment 2

[Adam Roach [:abr]]

Comment on attachment 721520 [details] [diff] [review]
Include filenames in WebRTC log messages

Review of attachment 721520 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/automation.py.in
@@ +828,5 @@
>  
>      # Additional temporary logging while we try to debug some intermittent
>      # WebRTC conditions. This is necessary to troubleshoot bugs 841496,
>      # 841150, and 839677 (at least)
> +    env['NSPR_LOG_MODULES'] = 'signaling:5,mtransport:3'

Note that this isn't increasing the amount of logging we do; the changes in CSFLog below allow for more fine-grained differentiation of log messages, such that what was previously emitted at 3 will now be emitted at 5.

Comment 3

[Adam Roach [:abr]]

Changing the title, as I'm revising the patch to also turn on select logging to help diagnose Bug 841496.

Comment 4

[Adam Roach [:abr]]

Attachment: Add filenames, fix module names, and turn on fsm_sm debugging

Comment 5

[Ethan Hugg [:ehugg]]

Comment on attachment 722478 [details] [diff] [review]
Add filenames, fix module names, and turn on fsm_sm debugging

Review of attachment 722478 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sipcc/include/cc_debug.h
@@ +26,1 @@
>  #define PLAT_DEBUG    if (PLATDebug)  buginf

You're close to excising buginf, buginf_msg, and err_msg with this patch, you may want to change the rest of these.

Comment 6

[Adam Roach [:abr]]

(In reply to Ethan Hugg [:ehugg] from comment #5)

> You're close to excising buginf, buginf_msg, and err_msg with this patch,
> you may want to change the rest of these.

Well, close, but not close enough:

$ find . -name '*.c' -exec egrep 'buginf|err_msg' '{}' \+ | wc
     105     609    9840

I agree this makes that cleanup easier, but it's still a somewhat large-ish task.

Comment 7

[Adam Roach [:abr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08096dc62f37

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08096dc62f37