Closed Bug 848195 Opened 13 years ago Closed 13 years ago

[Calendar] Calendar select hit-state is bad

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

Github pull request pointer
223 bytes, text/html
jlal
: review+
akeybl
: approval-gaia-v1+
Details
I've noticed that it's painful to interact with the Calendar select hit state. It's possible to tap on the button, which does not always trigger the select.
Assignee: nobody → kgrandon
Comment on attachment 721541 [details] Github pull request pointer Didn't try this myself but change makes perfect sense to me.... r+
Attachment #721541 - Flags: review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
FWIW, we should ask for approval to b2g18 on this bug. This is kinda sorta annoying UX-wise and probably worthwhile to take into v1-train.
Comment on attachment 721541 [details] Github pull request pointer This is a much better UX improvement to the edit event page. Without this patch, it's difficult to activate select boxes on the edit event screen. User impact if declined: Users will have a hard time interacting with the page. Testing completed: Been on master for > 2 weeks, no issues seen. Risk to taking this patch (and alternatives if risky): none. This patch is 7 characters! :)
Attachment #721541 - Flags: approval-gaia-v1?
Attachment #721541 - Flags: approval-gaia-v1? → approval-gaia-v1+
Uplifted commit c12c99b6862ef9da2662ab39458f7e1259a06f28 as: v1-train: 606fad72a005a357acf8b8b98e5abcc0aa7f79df
status-b2g18: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: