848264 - nsPluginHost.cpp: error: no member named 'strtol' in namespace 'std' (clang++ -stdlib=libc++)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jan Beich]

nsGUIEvent.h (pulled via nsIPresShell.h) no longer provides <cstdlib>
which was implicitly used by nsPluginHost.cpp for std::strtol

dom/plugins/base/nsPluginHost.cpp:2819:31: error:
      no member named 'strtol' in namespace 'std'; did you mean 'strtok'?
    long mimetypecount = std::strtol(reader.LinePtr(), nullptr, 10);
                         ~~~~~^~~~~~
                              strtok
/usr/include/string.h:119:7: note: 'strtok' declared here
char    *strtok(char * __restrict, const char * __restrict);
         ^
dom/plugins/base/nsPluginHost.cpp:2819:65: error:
      too many arguments to function call, expected 2, have 3
    long mimetypecount = std::strtol(reader.LinePtr(), nullptr, 10);
                         ~~~~~~~~~~~                            ^~
2 errors generated.

Comment 1

[Jan Beich]

Attachment: Explicitly include <cstdlib> after bug 835542.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/abe7aef12731

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/abe7aef12731