848291 - Update TransitionEvent to be compatible with the spec

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Better to do this after we have webidl bindings

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This seems to work.
Note, the default values for the dictionary aren't in the spec, but by adding
default values, dictionary handling becomes a bit simpler in C++.

https://tbpl.mozilla.org/?tree=Try&rev=c355dd741e27

Comment 2

[David Baron :dbaron:]

(In reply to Olli Pettay [:smaug] from comment #1)
> Note, the default values for the dictionary aren't in the spec, but by adding

Should they be?

Comment 3

[David Baron :dbaron:]

Comment on attachment 745299 [details] [diff] [review]
patch

In test_transitions_events.html, you should fix:

>// We should get no events from transitions on pseudo-elements.
>$("seven").setAttribute("foo", "bar");

in two ways:

 (1) fix the comment
 (2) add two started_test() calls before it, since it is now expected to yield two events.  Otherwise the test will return before the last 2 tests finish.



I also think we should just remove initTransitionEvent, though at this point that should go in a separate patch.  Can you do that?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: removed the comment in test

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1fac3f4bd83

but now I realized that perhaps I misunderstood the comment "in two ways"

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: additional patch for the test

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca8ab638f99

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

(In reply to David Baron [:dbaron] (don't cc:, use needinfo? instead) from comment #2)
> (In reply to Olli Pettay [:smaug] from comment #1)
> > Note, the default values for the dictionary aren't in the spec, but by adding
> 
> Should they be?
IMO it would make the spec easier to read.

Comment 9

[David Baron :dbaron:]

(In reply to Olli Pettay [:smaug] from comment #8)
> (In reply to David Baron [:dbaron] (don't cc:, use needinfo? instead) from
> comment #2)
> > (In reply to Olli Pettay [:smaug] from comment #1)
> > > Note, the default values for the dictionary aren't in the spec, but by adding
> > 
> > Should they be?
> IMO it would make the spec easier to read.

Does it change what the spec means?  It's not clear to me what's supposed to happen if a dictionary member without a default value is omitted.

Comment 10

[David Baron :dbaron:]

I suppose if there's no default value, the spec is supposed to define what happens when it's not present.  (I don't see this happening much, though.)

Comment 11

[David Baron :dbaron:]

Though it's not clear to me if giving the default values says anything about what happens when the entire dict is omitted.

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e1fac3f4bd83
https://hg.mozilla.org/mozilla-central/rev/0ca8ab638f99

Comment 13

[David Baron :dbaron:]

spec fixed in https://dvcs.w3.org/hg/csswg/rev/172f4f12f059

Comment 14

[David Baron :dbaron:]

... and https://dvcs.w3.org/hg/csswg/rev/3ee3ec0b5a5b

Comment 15

[Jean-Yves Perrier [:teoli]]

I documented this:
https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent
https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent.pseudoElement
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23