Closed
Bug 848312
Opened 11 years ago
Closed 11 years ago
Avoid unnecessary harmless race identified by helgrind
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: bent.mozilla, Assigned: jseward)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
947 bytes,
patch
|
Details | Diff | Splinter Review |
Helgrind complains that we set mIsAutoArray on nsTArray's EmptyHdr from different threads. This is annoying but harmless since the EmptyHdr's mIsAutoArray can never change. Attached is one way to fix. Spun off from bug 551155, this is Julian's patch.
Attachment #721672 -
Flags: review?(justin.lebar+bug)
|
Reporter | |
Comment 1•11 years ago
|
||
Comment on attachment 721672 [details] [diff] [review] Patch, v1 Wait, I've confused myself on whether this is needed any more. Clearing review request until I can verify this again.
Attachment #721672 -
Flags: review?(justin.lebar+bug)
|
||
Comment 2•11 years ago
|
||
Yeah, I added the first clause in that if statement in bug 844820. It's not clear to me why we need the second one.
|
|
Reporter | |
Comment 3•11 years ago
|
||
I think we're ok here now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•