Closed Bug 848385 Opened 8 years ago Closed 7 years ago

Running make package twice in a row with MOZ_ENABLE_SZIP is broken

Categories

(Core :: mozglue, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files, 2 obsolete files)

The second time, we're trying to re-szip an already szipped file.
Blocks: 848764
There are other problems, too, like running file_id on szipped files.
Depends on: 855823
Depends on: 855824
No longer depends on: 855823
Attached patch Avoid recompressing a szip (obsolete) — Splinter Review
Attachment #732418 - Flags: review?(nfroyd)
Assignee: nobody → mh+mozilla
Attachment #732418 - Flags: review?(nfroyd) → review+
Component: Build Config → mozglue
Attachment #732418 - Attachment is obsolete: true
For whoever comes here first. The other patch in this bug changes the szip executable such that it takes only one argument and does in-place compression, which removes the need for the mv.
Attachment #735041 - Flags: review?(ted)
Attachment #735041 - Flags: review?(khuey)
Blocks: 859705
And don't error out when trying to decompress something that is not compressed. Makes things easier for other scripts.
Attachment #735115 - Flags: review?(nfroyd)
Attachment #735038 - Attachment is obsolete: true
Attachment #735038 - Flags: review?(nfroyd)
Attachment #735041 - Flags: review?(ted)
Comment on attachment 735115 [details] [diff] [review]
Avoid recompressing a szip, and (de)compress in-place (but still with a temporary file)

Review of attachment 735115 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/szip.cpp
@@ +535,5 @@
>    }
>  
> +  std::stringstream tmpOutStream;
> +  tmpOutStream << firstArg[0] << ".sz." << getpid();
> +  std::string tmpOut(tmpOutStream.str());

Using mkstemp might be a little nicer, though you'd have to change FileBuffer to accept an existing fd as an argument.
Attachment #735115 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/10f03c8cf438
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.