848386 - Convert SVGDocument to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Like the summary says.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Don't preserve our wrapper until we have one so unforgeable property setup won't try to preserve it.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Implement a WebIDL equivalent for nsDocumentSH::PostCreate setting up the document as an own property on the Window.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Rename nsSVGDocument to mozilla::dom::SVGDocument.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Rename nsXMLDocument to mozilla::dom::XMLDocument.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Convert SVGDocument to WebIDL.

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 722373 [details] [diff] [review]
part 2.  Implement a WebIDL equivalent for nsDocumentSH::PostCreate setting up the document as an own property on the Window.

Review of attachment 722373 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +11102,5 @@
> +bool
> +nsIDocument::PostCreateWrapper(JSContext* aCx, JSObject *aNewObject)
> +{
> +  // This is just a hack around the fact that window.document is not
> +  // [Unforgeable] yet.

Add this above the function, I thought it was about the MOZ_ASSERT :-).

Comment 9

[Boris Zbarsky [:bzbarsky]]

> Add this above the function,

Done.

Comment 10

[Peter Van der Beken [:peterv]]

Comment on attachment 722374 [details] [diff] [review]
part 3.  Rename nsSVGDocument to mozilla::dom::SVGDocument.

Review of attachment 722374 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/document/src/nsSVGDocument.h
@@ +37,5 @@
>    virtual nsXPCClassInfo* GetClassInfo();
>  };
>  
> +} // namespace dom
> +} // namespace mozilla 

Trailing whitespace.

Comment 11

[Peter Van der Beken [:peterv]]

Comment on attachment 722375 [details] [diff] [review]
part 4.  Rename nsXMLDocument to mozilla::dom::XMLDocument.

Review of attachment 722375 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/xml/document/src/nsXMLDocument.cpp
@@ +264,1 @@
>                            nsIPrincipal* aPrincipal)

Reindent second line.

Comment 12

[Peter Van der Beken [:peterv]]

Comment on attachment 722376 [details] [diff] [review]
part 5.  Convert SVGDocument to WebIDL.

Review of attachment 722376 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/document/src/SVGDocument.cpp
@@ +113,5 @@
>  }
>  
> +JSObject*
> +SVGDocument::WrapNode(JSContext *aCx, JSObject *aScope,
> +                      bool *aTriedToWrap)

aTriedToWrap is gone.

::: content/svg/document/src/SVGDocument.h
@@ +44,5 @@
> +  nsSVGElement* GetRootElement(ErrorResult& aRv);
> +
> +protected:
> +  virtual JSObject* WrapNode(JSContext *aCx, JSObject *aScope,
> +                             bool *aTriedToWrap) MOZ_OVERRIDE;

aTriedToWrap is gone.

Comment 13

[Boris Zbarsky [:bzbarsky]]

> Trailing whitespace.

Fixed.

> Reindent second line.

Done.

> aTriedToWrap is gone.

Merged.

Pushed:
   https://hg.mozilla.org/integration/mozilla-inbound/rev/4612e210962a
   https://hg.mozilla.org/integration/mozilla-inbound/rev/cb6dc8e4c334
   https://hg.mozilla.org/integration/mozilla-inbound/rev/314f8ecec74f
   https://hg.mozilla.org/integration/mozilla-inbound/rev/11efd85f2af1
   https://hg.mozilla.org/integration/mozilla-inbound/rev/21ebbbb3467a

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4612e210962a
https://hg.mozilla.org/mozilla-central/rev/cb6dc8e4c334
https://hg.mozilla.org/mozilla-central/rev/314f8ecec74f
https://hg.mozilla.org/mozilla-central/rev/11efd85f2af1
https://hg.mozilla.org/mozilla-central/rev/21ebbbb3467a