848415 - [Dialer] Create performance tests for the call log

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8652

Pointer to Github pull-request

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 725042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8652

cool!

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Thanks Etienne!

https://github.com/mozilla-b2g/gaia/commit/7fc1cc5c5d3bfdcefc48efcb1ed0a3e973b89862

Comment 5

[Anthony Ricaud (:rik)]

FYI, this test doesn't show up on Datazilla because of bug 851195. The fact that FTU fails is a problem for the next app to be tested and that's dialer right now. See the output of http://qa-selenium.mv.mozilla.com:8080/view/B2G/job/b2g.unagi.gaia.master.mozperftest/152/artifact/perf.json

Comment 6

[Anthony Ricaud (:rik)]

And now, it doesn't show up because the reference-workload can't be created for the dialer.

"Skipped dialer history - no communications DB directory found..."

http://qa-selenium.mv.mozilla.com:8080/view/B2G/job/b2g.unagi.gaia.master.mozperftest/159/consoleText

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Thanks for the information Rik!

I am afraid that I have no access to the link that you are providing :(.

I noticed that the reference workload could not be created for the dialer while developing these tests as the patch landed in https://github.com/mozilla-b2g/gaia/pull/8546 wasn't enough. I reported it to Gregor Wagner (reviewer of the previous PR) and it seems that Jon Hylands already fixed it in bug 851249. Is this still an issue after bug 851249 landed?

Comment 8

[Anthony Ricaud (:rik)]

(Sorry for the link behind our VPN, I forgot about that.)

Let's followup in bug 852541 as it doesn't seem trivial to fix.

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 725042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8652

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Harder to track performance improvements on v1-train
Testing completed: 
Risk to taking this patch (and alternatives if risky): low, no functional change
String or UUID changes made by this patch:

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 725042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8652

Basically npotb, approving for uplift.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 7fc1cc5c5d3bfdcefc48efcb1ed0a3e973b89862
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 12

[Anthony Ricaud (:rik)]

It looks like this merge conflicts because of bug 845274 not merged yet.

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 7fc1cc5c5d3bfdcefc48efcb1ed0a3e973b89862 as:
v1-train: f2b6d1f39c6c6c495b853e13377360ab01484d8f